Skip to content

Add Bresenham Line Algorithm to GridMap Drawing #105292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Repiteo merged 1 commit into from
Nov 13, 2025
+61 −20
Merged

Add Bresenham Line Algorithm to GridMap Drawing #105292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 61 additions & 20 deletions modules/gridmap/editor/grid_map_editor_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

#include "grid_map_editor_plugin.h"

#include "core/math/geometry_2d.h"
#include "core/os/keyboard.h"
#include "editor/editor_main_screen.h"
#include "editor/editor_node.h"
Expand Down Expand Up @@ -435,26 +436,66 @@ bool GridMapEditor::do_input_action(Camera3D *p_camera, const Point2 &p_point, b
return true;
}

if (input_action == INPUT_PAINT) {
SetItem si;
si.position = cursor_gridpos;
si.new_value = selected_palette;
si.new_orientation = cursor_rot;
si.old_value = node->get_cell_item(cursor_gridpos);
si.old_orientation = node->get_cell_item_orientation(cursor_gridpos);
set_items.push_back(si);
node->set_cell_item(cursor_gridpos, selected_palette, cursor_rot);
return true;
} else if (input_action == INPUT_ERASE) {
SetItem si;
si.position = cursor_gridpos;
si.new_value = -1;
si.new_orientation = 0;
si.old_value = node->get_cell_item(cursor_gridpos);
si.old_orientation = node->get_cell_item_orientation(cursor_gridpos);
set_items.push_back(si);
node->set_cell_item(cursor_gridpos, -1);
return true;
if (input_action == INPUT_PAINT || input_action == INPUT_ERASE) {
LocalVector<Vector3i> cells;
if (!set_items.is_empty()) {
Vector3i last_si = (--set_items.end())->position;
// Manipulate Vector3i into Point2i by ignoring the edit_axis.
int i = edit_axis == 0 ? 1 : 0;
int j = edit_axis == 2 ? 1 : 2;
Point2i from_cell = Point2i(last_si[i], last_si[j]);
Point2i to_cell = Point2i(cursor_gridpos[i], cursor_gridpos[j]);

Vector<Point2i> cells_2d = Geometry2D::bresenham_line(from_cell, to_cell);

switch (edit_axis) {
case 0:
for (const Point2i &cell_2d : cells_2d) {
cells.push_back(Vector3i(edit_floor[0], cell_2d[0], cell_2d[1]));
}
break;
case 1:
for (const Point2i &cell_2d : cells_2d) {
cells.push_back(Vector3i(cell_2d[0], edit_floor[1], cell_2d[1]));
}
break;
case 2:
for (const Point2i &cell_2d : cells_2d) {
cells.push_back(Vector3i(cell_2d[0], cell_2d[1], edit_floor[2]));
}
break;
default:
break;
}
} else {
cells.push_back(cursor_gridpos);
}

if (input_action == INPUT_PAINT) {
for (const Vector3i &cell_v : cells) {
SetItem si;
si.position = cell_v;
si.new_value = selected_palette;
si.new_orientation = cursor_rot;
si.old_value = node->get_cell_item(cell_v);
si.old_orientation = node->get_cell_item_orientation(cell_v);
set_items.push_back(si);
node->set_cell_item(cell_v, selected_palette, cursor_rot);
}
return true;
} else if (input_action == INPUT_ERASE) {
for (const Vector3i &cell_v : cells) {
SetItem si;
si.position = cell_v;
si.new_value = -1;
si.new_orientation = 0;
si.old_value = node->get_cell_item(cell_v);
si.old_orientation = node->get_cell_item_orientation(cell_v);
set_items.push_back(si);
node->set_cell_item(cell_v, -1);
}
return true;
}
}

return false;
Expand Down