Build profile: Fix option names, add missing options#104967
Build profile: Fix option names, add missing options#104967akien-mga wants to merge 1 commit intogodotengine:masterfrom
Conversation
| "disable_navigation_2d", | ||
| "disable_navigation_3d", | ||
| "disable_xr", | ||
| "rendering_device", // FIXME: there's no scons option to disable rendering device |
There was a problem hiding this comment.
Once this PR is merged, #103100 should be rebased and amended to solve this FIXME, and add the rendering method options here too.
It might also start being a bit heavy UI wise, so maybe rendering features should be moved to their own category, like the text handling features.
And while at it maybe 2D and 3D could be categories too? That would be for a separate PR though, not #103100.
| TTRC("Vulkan backend of RenderingDevice."), | ||
| TTRC("Direct3D 12 backend of RenderingDevice (Windows)."), | ||
| TTRC("Metal backend of RenderingDevice (macOS and iOS)."), | ||
| TTRC("Advanced GUI nodes: Dialogs, Tree, RichTextLabel, TextEdit, GraphEdit, and more."), |
There was a problem hiding this comment.
We'll need better documentation on this somewhere, currently you need to read the source code to know what this impacts. It also seems pretty arbitrary and removing stuff like RichTextLabel likely makes it unusable for most games, even if they aren't UI heavy.
|
I actually have the changes for that locally, just haven't pushed them yet to my draft PR. Edit: Pushed. Actually, I think I can already take that PR out of its draft state. The few dependency PRs missing can have the build option added on their own ends. |
|
Ah I see. Superseded by #103719 then. |
2 participants
Fixes #104965.
I didn't test, could you make sure this works as expected @YeldhamDev?