Revert "Add built-in GUI to display license notices"#103906
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Mar 11, 2025
Merged
Revert "Add built-in GUI to display license notices"#103906Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
This reverts commit daa6198.
akien-mga
approved these changes
Mar 10, 2025
Member
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
Given the pushback on the original implementation, I agree we should take a step back and rework the proposal.
I still think we need to do more to make it trivial for users to comply with third-party licenses Godot relies on, but let's go back to the drawing board and make a proposal that takes into account the user feedback.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After internal discussion based on the feedback received, this reverts commit daa6198 / #79599.
I will work on a follow-up PR to achieve the same goal.
Special thanks to @Calinou for their original PR. We need something like this in order to make games made with Godot at least more compliant.
Fixes #103830 (partially).