Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use correct godot-cpp branch #103514

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Mar 3, 2025

Currently, it seems like CI using the master branch of godot-cpp, rather than the one we have configured.

Let's see if this works!

@dsnopek dsnopek added this to the 4.x milestone Mar 3, 2025
@dsnopek dsnopek requested a review from a team as a code owner March 3, 2025 17:30
@dsnopek
Copy link
Contributor Author

dsnopek commented Mar 3, 2025

This seems to work:

Selection_280

Previously, it wouldn't list ref at all

This too:

Selection_281

@dsnopek dsnopek requested review from akien-mga and Repiteo March 3, 2025 17:41
@dsnopek dsnopek added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Mar 3, 2025
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, good catch!

@Repiteo Repiteo modified the milestones: 4.x, 4.5 Mar 3, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Mar 3, 2025

It is odd though, that the env section in godot-cpp-build/action.yml seemed to not do anything. Maybe called actions don't store environment variables the same as actual workflows? In any case, you can remove lines 4-6 on that file, as they don't seem to work.

@dsnopek dsnopek force-pushed the github-actions-godot-cpp branch from ffb5588 to 70bace7 Compare March 3, 2025 18:09
@dsnopek
Copy link
Contributor Author

dsnopek commented Mar 3, 2025

you can remove lines 4-6 on that file

Whoops! I thought I had removed them :-)

Updated in my latest push!

@akien-mga akien-mga merged commit a3dcd98 into godotengine:master Mar 4, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants