Skip to content

Make the resource type's default theme item editable in Theme editor#102394

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
Rindbee:make-the-resource-type-default-theme-item-editable
Mar 23, 2026
Merged

Make the resource type's default theme item editable in Theme editor#102394
akien-mga merged 1 commit into
godotengine:masterfrom
Rindbee:make-the-resource-type-default-theme-item-editable

Conversation

@Rindbee
Copy link
Copy Markdown
Contributor

@Rindbee Rindbee commented Feb 4, 2025

In most cases, we may only need to modify some properties of the default resource instead of all. But click the plus icon to override item, it will use an empty object to override. Allow EditorResourcePicker to be editable, you can use the Make Unique option to create a copy and then edit it.

001.mp4

@AThousandShips AThousandShips added this to the 4.x milestone Feb 4, 2025
@Repiteo Repiteo requested a review from a team as a code owner February 17, 2026 20:10
@Rindbee Rindbee force-pushed the make-the-resource-type-default-theme-item-editable branch from d46085b to d693e1e Compare March 19, 2026 22:53
@Rindbee Rindbee requested a review from a team as a code owner March 19, 2026 22:53
@YeldhamDev
Copy link
Copy Markdown
Member

  • Clearing a default item and then undoing it doesn't set it back.
  • Making a default item unique and undoing it makes the inspector show the property as empty.
  • Not a regression from this PR, but the "Edit" button is available and does nothing when clicked. It would be nice if it behaved like the "Make Unique" option, if possible.

In most cases, we may only need to modify some properties of the default
resource instead of all. But click the plus icon to override item, it
will use an empty object to override. Allow `EditorResourcePicker` to be
editable, you can use the **Make Unique** option to create a copy and
then edit it.
@Rindbee Rindbee force-pushed the make-the-resource-type-default-theme-item-editable branch from d693e1e to 2c7071d Compare March 20, 2026 01:01
@Rindbee
Copy link
Copy Markdown
Contributor Author

Rindbee commented Mar 20, 2026

  • Clearing a default item and then undoing it doesn't set it back.
1.mp4
  • Making a default item unique and undoing it makes the inspector show the property as empty.
2.mp4
  • Not a regression from this PR, but the "Edit" button is available and does nothing when clicked. It would be nice if it behaved like the "Make Unique" option, if possible.

Perhaps it's because the property doesn't actually exist. This issue also occurs within the control's theme overrides.

Fixed in #117659.

2.mp4

@akien-mga akien-mga modified the milestones: 4.x, 4.7 Mar 23, 2026
@akien-mga akien-mga merged commit 00fd52a into godotengine:master Mar 23, 2026
20 checks passed
@akien-mga
Copy link
Copy Markdown
Member

Thanks!

@Rindbee Rindbee deleted the make-the-resource-type-default-theme-item-editable branch March 24, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants