-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tests for uid://
encoding and decoding
#100970
Add some tests for uid://
encoding and decoding
#100970
Conversation
Can be rebased on top of #100976 and tweaked to have the same test suite (I think it deserves its own one), with the |
4eb41a4
to
abb2796
Compare
@AThousandShips I have updated the tests and rebased on top of your commits now - let me know what you think! |
abb2796
to
11ae44b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unsure if the rest for leading a
should be included, it might be considered an implementation detail, and it just shows that irregular input is handled gracefully
But it can be removed if we choose to sanitize UID decoding in the future
Thanks! I don't seem to have merge permissions - do we need someone else to press that button? |
The production team handles merges, you shouldn't do that on your own (and there should be at least one more approval as well from relevant teams) |
11ae44b
to
e5e0fb1
Compare
e5e0fb1
to
2b5dd99
Compare
uid://
encoding and decoding
Thanks! And congrats for your first merged Godot contribution 🎉 |
I have added some basic uid encoding tests. See also #100969 for some details on the corner cases of our current implementation, documented in the test cases here.