Replace List used as stack with LocalVector#100433
Closed
YYF233333 wants to merge 2 commits intogodotengine:masterfrom
Closed
Replace List used as stack with LocalVector#100433YYF233333 wants to merge 2 commits intogodotengine:masterfrom
List used as stack with LocalVector#100433YYF233333 wants to merge 2 commits intogodotengine:masterfrom
Conversation
Contributor
Author
|
Same as #99936. I’ll recreate this one with a better approach and scope once I've done the overall evaluating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #99955 and include it.
Replace local variable
Listused as stack (which means nopush_front()/pop_front()). Class members are planned in following PR.Most of these variables have a lifetime no longer than a screen of code, so should be easy to review.
The one in
editor/filesystem_dock.cppis named asqueuewhile it is actually a stack.