Optimization: Use static string concatenation instead of repetitive StringBuilder.append where appropriate.#100127
Open
Ivorforce wants to merge 1 commit intogodotengine:masterfrom
Open
Conversation
Ivorforce
changed the title
StringBuilder.append where appropriate.StringBuilder.append where appropriate.
Contributor
|
Thanks! This makes sense to me (I may be responsible for adding like ~50% of those lines: all the multiview and external image ones - sorry :-)) |
Ivorforce
force-pushed
the
string-builder-append
branch
from
f663758 to
1fa1554
Compare
Member
Author
|
No worries, it's not likely to make a big difference 😄 |
Contributor
|
Are the glslang changes worth doing? That's all third-party, so you'll need to include a patch, and those changes will need to be re-applied every time it's updated. |
…append` calls where appropriate.
Ivorforce
force-pushed
the
string-builder-append
branch
from
1fa1554 to
5d3f9aa
Compare
Member
Author
Nope, definitely isn't worth doing! I just missed that it was in |
kiroxas
approved these changes
Dec 8, 2024
Contributor
kiroxas
left a comment
kiroxas
left a comment
There was a problem hiding this comment.
Definitely leave that to the compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across this while testing
StringBuilderefficiency (#77158 (comment)).append, especially forStringBuilder, is most effective when used with few, long strings.This will likely not have a noticeable effect, but it will be slightly faster than before.