Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project tag theme changing #100017

Closed
wants to merge 1 commit into from

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Dec 4, 2024

Fix theme changing for project tag buttons.

Before

bugfix_none

After

bugfix

@Chaosus Chaosus requested a review from a team as a code owner December 4, 2024 18:02
@Chaosus Chaosus added this to the 4.4 milestone Dec 4, 2024
@Chaosus Chaosus force-pushed the fix_project_tag_theming branch from 35b443f to c4d6b21 Compare December 4, 2024 18:05
@KoBeWi
Copy link
Member

KoBeWi commented Dec 4, 2024

ProjectTags have theme type variation, so adding overrides shouldn't be necessary. The bug might be somewhere else.

@Chaosus
Copy link
Member Author

Chaosus commented Dec 9, 2024

@KoBeWi I'm not sure that the theme changing working like you said + this PR may work as a temporary fix.

@KoBeWi
Copy link
Member

KoBeWi commented Jan 1, 2025

Superseded by #100999
Thanks for the contribution.

@KoBeWi KoBeWi closed this Jan 1, 2025
@KoBeWi KoBeWi added the archived label Jan 1, 2025
@KoBeWi KoBeWi removed this from the 4.4 milestone Jan 1, 2025
@Chaosus Chaosus deleted the fix_project_tag_theming branch January 2, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants