Optimize String::is_valid_filename() and String::validate_filename()
#100015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilename characters, instead of re-splitting each call.
Ivorforce
force-pushed
the
is-valid-filename-cache
branch
from
6c01e8e to
0d2e13b
Compare
kiroxas
reviewed
Dec 4, 2024
clayjohn
approved these changes
Dec 5, 2024
adamscott
changed the title
String::is_valid_filename() and String::validate_filename()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by caching invalid filename characters, instead of re-splitting each call.
The relevant Godot benchmark reveals
is_valid_filenameis almost 10x faster, andvalidate_filenameis about 4x faster.