Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch of snap results between key movement and cursor movement in AnimationTrackEditor #91729

Closed
TokageItLab opened this issue May 8, 2024 · 0 comments · Fixed by #92670
Closed

Mismatch of snap results between key movement and cursor movement in AnimationTrackEditor #91729

TokageItLab opened this issue May 8, 2024 · 0 comments · Fixed by #92670
Assignees
@TokageItLab
Labels
bug topic:animation topic:editor
Milestone
4.3

Comments

@TokageItLab
Copy link
Member

TokageItLab commented May 8, 2024 •
edited
Loading

Tested versions

4.3.dev6 (no error on cursor, key has error)
4.1.3, 4.2.2 (match the result but both have float error)

System information

Any

Issue description

The default snap setting for animation is now 0.0333 second, but there is a problem with the snap result not matching the key and current time cursor at this time.

snapdiff.mp4

There seems to have been a fix for the cursor at some point (Maybe #87250? I will test later), so the key movement needs to follow suit.

Steps to reproduce

Use snap with float second value and move key and timeline current position cursor.

Minimal reproduction project (MRP)

snapanim.zip
@TokageItLab TokageItLab added this to the 4.3 milestone May 8, 2024
@TokageItLab TokageItLab self-assigned this May 23, 2024
@TokageItLab TokageItLab mentioned this issue Jun 2, 2024
Merged
AtlaStar added a commit to AtlaStar/godot that referenced this issue Sep 28, 2024
@AtlaStar
Allow fractional FPS values in Animation Editor
403c9e8 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
@AtlaStar AtlaStar mentioned this issue Sep 28, 2024
Merged
AtlaStar added a commit to AtlaStar/godot that referenced this issue Sep 29, 2024
@AtlaStar
Allow fractional FPS values in Animation Editor
c812c3d 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
AtlaStar added a commit to AtlaStar/godot that referenced this issue Oct 2, 2024
@AtlaStar
Allow fractional FPS values in Animation Editor
8dc6c77 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
AtlaStar added a commit to AtlaStar/godot that referenced this issue Oct 2, 2024
@AtlaStar
Allow fractional FPS values in Animation Editor
8a8d40c 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
laurentmackay pushed a commit to metapfhor/godot that referenced this issue Oct 30, 2024
@AtlaStar @laurentmackay
Allow fractional FPS values in Animation Editor
2716838 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
JayTropper pushed a commit to JayTropper/godot that referenced this issue Nov 6, 2024
@AtlaStar @JayTropper
Allow fractional FPS values in Animation Editor
13c28cf 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
ChrisBase pushed a commit to ChrisBase/godot that referenced this issue Nov 15, 2024
@AtlaStar @ChrisBase
Allow fractional FPS values in Animation Editor
4edc3c2 
Closes godotengine#97548. Care also taken to not reopen issue godotengine#92273 by ensuring that the value rounds to the nearest sixteenth. Optionally any factor of 2 should work while ensuring that there isn't error accumulation.

Further testing to ensure issue godotengine#91729 isn't reopened, but initial testing suggests that the issue will not reopen with this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TokageItLab TokageItLab

Labels
bug topic:animation topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix unstable AnimationTrackEditor snapping value TokageItLab/godot
1 participant
@TokageItLab