Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing ClassDB.class_get_property(null,"") crashes Godot #47573

Closed
qarmin opened this issue Apr 2, 2021 · 0 comments · Fixed by #47576
Closed

Executing ClassDB.class_get_property(null,"") crashes Godot #47573

qarmin opened this issue Apr 2, 2021 · 0 comments · Fixed by #47576

Comments

@qarmin
Copy link
Contributor

qarmin commented Apr 2, 2021

Godot version:
3.3.rc.custom_build. ed1f5c2

OS
Ubuntu 20.04 - Ubuntu 3.36 X11

Issue description:
Executing

ClassDB.class_get_property(null,"")

or

ClassDB.class_set_property(null,"","")

crashes with backtrace

[1] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7f23c16d2210] (??:0)
[2] Object::get_class_name() const (/mnt/Miecz/godot3.2/./core/object.h:658)
[3] ClassDB::get_property(Object*, StringName const&, Variant&) (/mnt/Miecz/godot3.2/core/class_db.cpp:1068)
[4] _ClassDB::get_property(Object*, StringName const&) const (/mnt/Miecz/godot3.2/core/bind/core_bind.cpp:2953)
[5] MethodBind2RC<Variant, Object*, StringName const&>::call(Object*, Variant const**, int, Variant::CallError&) (/mnt/Miecz/godot3.2/./core/method_bind.gen.inc:2105 (discriminator 11))
[6] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/mnt/Miecz/godot3.2/core/object.cpp:919 (discriminator 1))
[7] Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) (/mnt/Miecz/godot3.2/core/variant_call.cpp:1149 (discriminator 1))
[8] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript_function.cpp:1089)
[9] GDScriptInstance::_ml_call_reversed(GDScript*, StringName const&, Variant const**, int) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript.cpp:1239)
[10] GDScriptInstance::call_multilevel_reversed(StringName const&, Variant const**, int) (/mnt/Miecz/godot3.2/modules/gdscript/gdscript.cpp:1248)
[11] Node::_notification(int) (/mnt/Miecz/godot3.2/scene/main/node.cpp:152)
[12] Node::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/main/node.h:46 (discriminator 14))
[13] CanvasItem::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/2d/canvas_item.h:166 (discriminator 3))
[14] Node2D::_notificationv(int, bool) (/mnt/Miecz/godot3.2/./scene/2d/node_2d.h:38 (discriminator 3))
[15] Object::notification(int, bool) (/mnt/Miecz/godot3.2/core/object.cpp:931)
[16] Node::_propagate_ready() (/mnt/Miecz/godot3.2/scene/main/node.cpp:197)
[17] Node::_propagate_ready() (/mnt/Miecz/godot3.2/scene/main/node.cpp:186 (discriminator 2))
[18] Node::_set_tree(SceneTree*) (/mnt/Miecz/godot3.2/scene/main/node.cpp:2626)
[19] SceneTree::init() (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:466)
[20] OS_X11::run() (/mnt/Miecz/godot3.2/platform/x11/os_x11.cpp:3635)
[21] /usr/bin/godot(main+0x125) [0x170090b] (/mnt/Miecz/godot3.2/platform/x11/godot_x11.cpp:57)
[22] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f23c16b30b3] (??:0)
[23] /usr/bin/godot(_start+0x2e) [0x170072e] (??:?)
akien-mga added a commit that referenced this issue Apr 2, 2021
…crash

Fix crash on null object in ClassDB.get_property() and set_property() (Fix #47573)
@akien-mga akien-mga added this to the 4.0 milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants