-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioStreamPlayer high-freq artifact, pops, stereo channel corruption #40630
Comments
Related to #22016? |
edit: the ogg was mangled by ffmpeg which is why it looks different. Ignore this. That could explain the awful playback issues in the mono ogg file. I wasn't able to reproduce the high pitched sound you referred to though. I may try some more tomorrow but it's getting late. Might be bedtime :) |
Good to hear! So I guess something in 4.0 fixed that issue. Thanks for taking a look at it! |
Nevermind! There was indeed a bug in the mono->stereo conversion of the ogg stream. I have a fix. I also found a fix for some ringing in the ogg/mp3 streams that might be what you noticed, but my hearing isn't great so I don't want to say for sure. |
(cherry picked from commit f993d2e)
Is this still reproducible in 4.0 RC 3 or later? |
Godot version:
3.2.2 Stable
OS/device including version:
Windows 10
Issue description:
Video example:
https://youtu.be/PQQmKecHrec
Steps to reproduce:
(See video example)
In the provided project, drop the samples onto the AudioStreamPlayer, and run the project.
Listen to the output sound.
Minimal reproduction project:
AudioStreamPlayerBug.zip
The text was updated successfully, but these errors were encountered: