Skip to content

Commit

Permalink
Change warning muting so it affects all levels, but locally
Browse files Browse the repository at this point in the history
  • Loading branch information
RandomShaper committed Aug 26, 2024
1 parent e53dc80 commit 712054f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ else: # GCC, Clang
if cc_version_major >= 11: # Broke on MethodBind templates before GCC 11.
env.Append(CCFLAGS=["-Wlogical-op"])
elif methods.using_clang(env) or methods.using_emcc(env):
env.Append(CCFLAGS=["-Wimplicit-fallthrough", "-Wno-undefined-var-template"])
env.Append(CCFLAGS=["-Wimplicit-fallthrough"])
elif env["warnings"] == "all":
env.Append(CCFLAGS=["-Wall"] + common_warnings)
elif env["warnings"] == "moderate":
Expand Down
5 changes: 5 additions & 0 deletions core/os/safe_binary_mutex.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@

#ifdef THREADS_ENABLED

#pragma clang diagnostic push

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check failure on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

the following warning is treated as an error

Check warning on line 40 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'
#pragma clang diagnostic ignored "-Wundefined-var-template"

Check failure on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check warning on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check warning on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check warning on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check failure on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check warning on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check warning on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check warning on line 41 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

// A very special kind of mutex, used in scenarios where these
// requirements hold at the same time:
// - Must be used with a condition variable (only binary mutexes are suitable).
Expand Down Expand Up @@ -105,6 +108,8 @@ class MutexLock<SafeBinaryMutex<Tag>> {
}
};

#pragma clang diagnostic pop

Check failure on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check warning on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check warning on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check warning on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor (target=editor, tests=yes)

unknown pragma 'clang'

Check failure on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check failure on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, everything disabled)

ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

Check warning on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check warning on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

Check warning on line 111 in core/os/safe_binary_mutex.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template (target=template_release)

unknown pragma 'clang'

#else // No threads.

template <int Tag>
Expand Down

0 comments on commit 712054f

Please sign in to comment.