Merge pull request #82502 from Rindbee/fix-bugs-in-bvh-for-3.x

[3.x] BVH - fix not refitting upward from leaf nodes
godotengine · Oct 1, 2023 · 3947c11 · 3947c11
2 parents 5f9cbe5 + 01c60dc
commit 3947c11
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/math/bvh_refit.inc b/core/math/bvh_refit.inc
@@ -134,7 +134,7 @@ void refit_branch(uint32_t p_node_id) {
 			TLeaf &leaf = _node_get_leaf(tnode);
 			if (leaf.is_dirty()) {
 				leaf.set_dirty(false);
-				refit_upward(p_node_id);
+				refit_upward(rp.node_id);
 			}
 		}
 	} // while more nodes to pop

diff --git a/core/math/bvh_structs.inc b/core/math/bvh_structs.inc
@@ -71,7 +71,7 @@ public:
 
 	void clear() {
 		num_items = 0;
-		set_dirty(true);
+		set_dirty(false);
 	}
 	bool is_full() const { return num_items >= MAX_ITEMS; }