Skip to content

Commit

Permalink
Merge pull request #90507 from Calinou/tests-disabled-error-on-test-c…
Browse files Browse the repository at this point in the history
…li-argument

Exit with an error if using `--test` on binary without unit tests compiled
  • Loading branch information
akien-mga committed Apr 18, 2024
2 parents 0dfb48e + 7467ce6 commit 35369b8
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions main/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -842,21 +842,26 @@ void Main::test_cleanup() {
#endif

int Main::test_entrypoint(int argc, char *argv[], bool &tests_need_run) {
#ifdef TESTS_ENABLED
for (int x = 0; x < argc; x++) {
if ((strncmp(argv[x], "--test", 6) == 0) && (strlen(argv[x]) == 6)) {
tests_need_run = true;
#ifdef TESTS_ENABLED
// TODO: need to come up with different test contexts.
// Not every test requires high-level functionality like `ClassDB`.
test_setup();
int status = test_main(argc, argv);
test_cleanup();
return status;
#else
ERR_PRINT(
"`--test` was specified on the command line, but this Godot binary was compiled without support for unit tests. Aborting.\n"
"To be able to run unit tests, use the `tests=yes` SCons option when compiling Godot.\n");
return EXIT_FAILURE;
#endif
}
}
#endif
tests_need_run = false;
return 0;
return EXIT_SUCCESS;
}

/* Engine initialization
Expand Down

0 comments on commit 35369b8

Please sign in to comment.