Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sky radiance size to 128 (from 64) in the Material Tester demo #220

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 19, 2018

This makes reflections look nicer, especially on materials with low roughness values. The performance impact is probably negligible.

Before:

material_tester_sky_radiance_size_64

After:

material_tester_sky_radiance_size_256

@reduz
Copy link
Member

reduz commented Feb 19, 2018 via email

@aaronfranke
Copy link
Member

Now that 3.1 is released and we have GLES 2, this should be re-based and re-tested.

@Calinou Calinou force-pushed the increase-sky-radiance-size branch from f0ca7a7 to 99a02ee Compare May 10, 2019 17:31
@Calinou Calinou changed the title Increase sky radiance size to 256 (from 64) in the Material Tester demo Increase sky radiance size to 512 (from 64) in the Material Tester demo May 10, 2019
@Calinou
Copy link
Member Author

Calinou commented May 10, 2019

Rebased. I also increased the value to 512 as it's the default value in Environment.

@Calinou Calinou force-pushed the increase-sky-radiance-size branch from 99a02ee to 734e38c Compare May 10, 2019 17:33
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A simple change, but looks much better. @akien-mga

@clayjohn
Copy link
Member

clayjohn commented Jun 5, 2019

Value should be set to 128 as that is the new default as of godotengine/godot#29182

Not sure what it is currently set at. Given the new changes 512 is a little too high. The visual difference between 128 and 512 is very slight.

@Calinou
Copy link
Member Author

Calinou commented Jun 5, 2019

@clayjohn It seems loading this PR automatically sets the radiance size to 128 now, as 512 was the prior default value. Godot doesn't save default properties in scene files (even in binary format, it seems), so it automtaically uses the new default value. I'll update the commit message accordingly.

However, radiance size 128 doesn't look as sharp as 512 previously did, but I guess it's good enough (it's still much better than the old 64 value):

image

This makes reflections look nicer, especially on materials with low
roughness values.
@Calinou Calinou force-pushed the increase-sky-radiance-size branch from 734e38c to 7f41a74 Compare June 5, 2019 11:39
@Calinou Calinou changed the title Increase sky radiance size to 512 (from 64) in the Material Tester demo Increase sky radiance size to 128 (from 64) in the Material Tester demo Jun 5, 2019
@akien-mga akien-mga merged commit 4bb717c into godotengine:master Jun 10, 2019
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the increase-sky-radiance-size branch May 4, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants