-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase sky radiance size to 128 (from 64) in the Material Tester demo #220
Increase sky radiance size to 128 (from 64) in the Material Tester demo #220
Conversation
And makes it crash on mobile, but I guess should be fine now thst es2
backend is coming along
…On Feb 19, 2018 15:24, "Hugo Locurcio" ***@***.***> wrote:
This makes reflections look nicer, especially on materials with low
roughness values. The performance impact is probably negligible.
------------------------------
You can view, comment on, or merge this pull request online at:
#220
Commit Summary
- Increase sky radiance size to 256 (from 64) in the Material Tester
demo
File Changes
- *M* 3d/material_testers/tester.scn
<https://github.com/godotengine/godot-demo-projects/pull/220/files#diff-0>
(0)
Patch Links:
- https://github.com/godotengine/godot-demo-projects/pull/220.patch
- https://github.com/godotengine/godot-demo-projects/pull/220.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#220>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF-Z22eRKBeFhHQF4wb705pA3hql2hhpks5tWbxMgaJpZM4SK8sC>
.
|
Now that 3.1 is released and we have GLES 2, this should be re-based and re-tested. |
f0ca7a7
to
99a02ee
Compare
Rebased. I also increased the value to 512 as it's the default value in Environment. |
99a02ee
to
734e38c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A simple change, but looks much better. @akien-mga
Value should be set to 128 as that is the new default as of godotengine/godot#29182 Not sure what it is currently set at. Given the new changes 512 is a little too high. The visual difference between 128 and 512 is very slight. |
@clayjohn It seems loading this PR automatically sets the radiance size to 128 now, as 512 was the prior default value. Godot doesn't save default properties in scene files (even in binary format, it seems), so it automtaically uses the new default value. I'll update the commit message accordingly. However, radiance size 128 doesn't look as sharp as 512 previously did, but I guess it's good enough (it's still much better than the old 64 value): |
This makes reflections look nicer, especially on materials with low roughness values.
734e38c
to
7f41a74
Compare
Thanks! |
This makes reflections look nicer, especially on materials with low roughness values. The performance impact is probably negligible.
Before:
After: