Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #581 from lilizoey/fix/static-mut-safety" #628

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion godot-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ codegen-lazy-fptrs = [
custom-godot = ["godot-ffi/custom-godot", "godot-codegen/custom-godot"]
double-precision = ["godot-codegen/double-precision"]
experimental-godot-api = ["godot-codegen/experimental-godot-api"]
experimental-threads = ["godot-ffi/experimental-threads"]
experimental-threads = []
trace = ["godot-ffi/trace"]

[dependencies]
Expand Down
4 changes: 2 additions & 2 deletions godot-core/src/builtin/meta/signature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ macro_rules! impl_varcall_signature_for_tuple {
let variant = Variant::from_var_sys_init(|return_ptr| {
let mut err = sys::default_call_error();
class_fn(
method_bind.0,
method_bind,
object_ptr,
variant_ptrs.as_ptr(),
variant_ptrs.len() as i64,
Expand Down Expand Up @@ -390,7 +390,7 @@ macro_rules! impl_ptrcall_signature_for_tuple {
];

let result = Rr::call(|return_ptr| {
class_fn(method_bind.0, object_ptr, type_ptrs.as_ptr(), return_ptr);
class_fn(method_bind, object_ptr, type_ptrs.as_ptr(), return_ptr);
});
result.unwrap_or_else(|err| return_error::<Self::Ret>(&call_ctx, err))
}
Expand Down
6 changes: 5 additions & 1 deletion godot-core/src/init/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

use godot_ffi as sys;

use std::cell;
use sys::GodotFfi;

use crate::builtin::{GString, StringName};
Expand All @@ -27,7 +28,10 @@ pub unsafe fn __gdext_load_library<E: ExtensionLibrary>(
EditorRunBehavior::AllClasses => false,
};

let config = sys::GdextConfig::new(tool_only_in_editor);
let config = sys::GdextConfig {
tool_only_in_editor,
is_editor: cell::OnceCell::new(),
};

sys::initialize(interface_or_get_proc_address, library, config);

Expand Down
1 change: 0 additions & 1 deletion godot-ffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ custom-godot = ["godot-bindings/custom-godot"]
codegen-fmt = ["godot-codegen/codegen-fmt"]
codegen-lazy-fptrs = ["godot-codegen/codegen-lazy-fptrs"]
experimental-godot-api = ["godot-codegen/experimental-godot-api"]
experimental-threads = []
trace = []

# TODO: get rid of paste and gensym, they are trivially implementable with proc-macros. Update cargo-deny.
Expand Down
324 changes: 0 additions & 324 deletions godot-ffi/src/binding/mod.rs

This file was deleted.

Loading
Loading