-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Merge pull request #581 from lilizoey/fix/static-mut-safety" #628
Revert "Merge pull request #581 from lilizoey/fix/static-mut-safety" #628
Conversation
Not really sure why CI is unhappy here. |
It seems this PR incurs compile error on
Removing that line compilation itself succeeds. (Of course idk if it works or not ..) |
Thanks for the heads up! I'll try it in the morning and see if it fixes it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't just revert all those changes to fix one issue. They improve on several other things, like thread safety.
We should isolate what causes the issue and fix that specifically.
In this case, IIRC the assumption that some global initialization would only be called once was violated -- it's called multiple timed in hot reloading, which panics? If so, we should hook the hot reload notification to a flag, which is then considered on reload.
@StatisMike This does indeed fix it! :) I prefer this as a workaround rather than a revert. I'll close this PR and open an issue to track it instead with a summary of our findings. |
Sounds good. I won't :) |
Fixed in #653. |
This reverts commit b4a91a6, reversing changes made to 6243fc6.
Hot reloads appear to have been broken by this PR. Putting in a revert to get hot reloading back up and running while the cause is investigated.