switch to timezone aware timestamps #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best practice with postgres is to use timestamps with timezone handling. This is done by using timestamptz instead of timestamp as the column type. With timestamp there is no understanding of timezones and so applications need to do all the timezone handling themselves including being consistent in what timezone they work with from release to release. With timestamptz postgres will convert any timestamp that comes in to be in UTC format and then will convert that back to the session's timezone when read back.
stanislas-m
approved these changes
May 15, 2019
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice with postgres is to use timestamps with timezone handling.
This is done by using timestamptz instead of timestamp as the column
type.
With timestamp there is no understanding of timezones and so
applications need to do all the timezone handling themselves including
being consistent in what timezone they work with from release to
release.
With timestamptz postgres will convert any timestamp that comes in to be
in UTC format and then will convert that back to the session's timezone
when read back.