Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 / review and unify column type translation #138

Open
19 tasks
sio4 opened this issue Sep 7, 2022 · 0 comments
Open
19 tasks

v2 / review and unify column type translation #138

sio4 opened this issue Sep 7, 2022 · 0 comments
Assignees
Labels
breaking change This feature / fix introduces breaking changes proposal A suggestion for a change, feature, enhancement, etc s: accepted was accepted or confirmed
Milestone

Comments

@sio4
Copy link
Member

sio4 commented Sep 7, 2022

It seems like there are some reasonable open issues regarding the column type translation from Fizz's to database's.

some findings are:

  • First, there is no policy for supported database engine version which is very important
  • Also, the purpose of colType() could be slightly confusing
  • in many cases, timestamp is just treated as datetime
  • only PostgreSQL's datetime has a timezone (but timestamp it not)
  • time is treated as datetime which should not be
  • date is treated as numeric in SQLite3
  • float and decimal are treated as the same (decimal) in most dialects
  • and most importantly, have no document for them

Related open issues and PRs (at this moment):

Also, related issues/PRs on the other modules:

Old issues/PRs related to this:

Other issues about an ID field which is restricted to be int or UUID

Date type definitions:

Release/Support/Lifecycle policy for database engines:

@sio4 sio4 added breaking change This feature / fix introduces breaking changes proposal A suggestion for a change, feature, enhancement, etc s: accepted was accepted or confirmed labels Sep 7, 2022
@sio4 sio4 added this to the v2 milestone Sep 7, 2022
@sio4 sio4 self-assigned this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This feature / fix introduces breaking changes proposal A suggestion for a change, feature, enhancement, etc s: accepted was accepted or confirmed
Projects
None yet
Development

No branches or pull requests

1 participant