Adding common types from attr #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
approved these changes
Oct 5, 2018
|
👍 |
paganotoni
changed the title
|
@gobuffalo/pop-managers this one is ready for review, please LMK if its looking good for you. |
stanislas-m
requested changes
Oct 23, 2018
database.yml
Outdated
| @@ -4,7 +4,10 @@ mysql: | |||
| host: {{ envOr "MYSQL_HOST" "127.0.0.1" }} | |||
| port: {{ envOr "MYSQL_PORT" "3306" }} | |||
| user: {{ envOr "MYSQL_USER" "root" }} | |||
| password: {{ envOr "MYSQL_PASSWORD" "root" }} | |||
| password: {{ envOr "MYSQL_PASSWORD" "root" }} | |||
| options: | |||
|
@stanislas-m all set, removed these options. |
stanislas-m
approved these changes
Oct 24, 2018
|
Thanks @paganotoni! |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markbates this PR adds common types to fizz translators, i started with Postgres and would love to know im moving in the right direction before going forward.