Group racing accesses into disjoint components #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accesses of a single location are grouped into disjoint components, i.e. connected components in the graph of accesses with
may_raceedges).This doesn't strictly improve precision, because all the same accesses are still printed, but it improves the precision and usability of the output by making it clearer, which accesses cannot race with which.
It makes sense to expose this information because the pairwise race checking internally knows (only previously only implicitly).
Example
In the added test
tests/regression/10-synch/05-two_unique_two_lock.c.Before
All accesses are printed under one warning.
After
Accesses are printed under two different warnings for the same location such that the two racing components have no races between each other, only internally: