Skip to content

fix(web): dev's command palette and PR code tab tests pass again #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 2 commits into from
Oct 28, 2026
Merged

fix(web): dev's command palette and PR code tab tests pass again #2036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98b0a00
fix(web): the command palette's Back button is reachable by assistive…
lidge-jun Oct 28, 2026
34aa815
test(web): the stale-commit reveal test renders a pull request that h…
lidge-jun Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions apps/web/src/components/pullRequest/PullRequestCodeTab.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,13 @@ const tab = (
refreshToken: number,
revealRequest: { readonly path: string; readonly nonce: number } | null = null,
selectedCommitOid: string | null = null,
tabDetail: PullRequestDetailView = detail,
) => (
<PullRequestCodeTab
scrollerRef={() => {}}
environmentId={EnvironmentId.make("environment")}
reference={detail}
detail={detail}
detail={tabDetail}
selectedCommitOid={selectedCommitOid}
onSelectedCommitChange={() => {}}
onRefresh={() => {}}
Expand Down Expand Up @@ -219,7 +220,16 @@ it("reveals a pending file across pages while a stale selected commit falls back
setup(true);
const container = document.createElement("div");
container.className = "flex h-[500px] w-[900px]";
await using screen = await render(tab(0, { path: "late.ts", nonce: 1 }, "gone"), { container });
// The diff scope menu only renders for a pull request that still has commits.
const keptCommit = {
oid: "kept",
messageHeadline: "Kept commit",
committedDate: "2026-09-01T00:00:00Z",
};
await using screen = await render(
tab(0, { path: "late.ts", nonce: 1 }, "gone", { ...detail, commits: [keptCommit] }),
{ container },
);

await expectFileHeaderShown(screen, container, "late.ts");
await expect
Expand Down
1 change: 0 additions & 1 deletion apps/web/src/components/ui/autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ function AutocompleteInput({
<div className="relative not-has-[>*.w-full]:w-fit w-full text-foreground has-disabled:opacity-64">
{startAddon && (
<div
aria-hidden="true"
className="[&_svg]:-mx-0.5 pointer-events-none has-[button]:pointer-events-auto absolute inset-y-0 start-px z-10 flex items-center ps-[calc(--spacing(3)-1px)] opacity-80 has-[+[data-size=sm]]:ps-[calc(--spacing(2.5)-1px)] [&_svg:not([class*='size-'])]:size-4.5 sm:[&_svg:not([class*='size-'])]:size-4"
data-slot="autocomplete-start-addon"
>
Expand Down
Loading