Repository navigation
fix(web): dev's command palette and PR code tab tests pass again - #2036
Merged
Merged
Conversation
… tech AutocompleteInput hid its start addon with aria-hidden, which also hid the interactive Back button the palette puts there. The icons placed in the addon already hide themselves, so the wrapper no longer does.
…as commits The diff scope menu renders only while the pull request has commits, but the test built its tab from a detail with none, so its "Diff scope: All commits" assertion could never pass and the test ran into its timeout.
lidge-jun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev's full goat-ci run (40621796632) fails goat-test on two web browser tests that are still broken on current dev.
CommandPalette.browser.test.tsx"focuses the search input when an open intent replaces the initial view":getByRole("button", { name: "Back" })never matches, although the button is in the DOM.AutocompleteInputwrapped itsstartAddoninaria-hidden="true", and the command palette puts its interactive Back button in that addon, so the button was hidden from screen readers and from role queries. The wrapper is built to hold buttons (has-[button]:pointer-events-auto), and the icons placed there (solar icons) already setaria-hiddenthemselves. Code fix: the wrapper no longer setsaria-hidden.PullRequestCodeTab.browser.test.tsx"reveals a pending file across pages while a stale selected commit falls back to all commits" (15s timeout): the diff scope menu renders only when the pull request has commits (orderedCommits.length > 0), but the test built its tab from a detail withcommits: []. Its "Diff scope: All commits" assertion could never pass. Test bug: that test now renders a pull request that still has one commit, as the sibling stale-commit test does. The selected commit stays "gone".Also failing in that run and already fixed on dev:
chat/useQueuedRunEdit.browser.test.tsx(#2005).Verification: I reproduced the CommandPalette failure locally once on dev 5030651 and confirmed the button exists under the
aria-hiddenwrapper. I found the PullRequestCodeTab cause by reading the source. Per the maintainer, browser tests no longer run on this Mac, so this PR's goat-test run is the proof.NOT RUN: browser tests locally after the change, and
vp run check:changed(paused by the maintainer; CI owns them). This change has no visual effect.Model and harness: anthropic/claude-opus-5-5 via GOAT (Codex harness).