Repository navigation
fix(cli): shell completions for the SSH helper describe the full CLI again - #2004
Merged
Merged
Conversation
…again bin.ts kept the pre-#1925 SSH helper branch after the fast path was added. It was only reachable for Effect CLI built-ins such as --completions, which it answered from a helper-only command tree. Remove the branch and its module; the fast-path test now also compares stdout for --version and the SSH probe.
Contributor
Author
|
CI on exact head 17c5788: all jobs pass except two failures that reproduce identically on dev and are not touched by this PR:
Every other server shard passes, including bin.fast-path.test.ts, which this PR fixes. Independent gpt-6.1-sol review: PASS with no findings on 17c5788. Dev evidence run: https://github.com/goat-si/goat/actions/runs/40621796632 (queued). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goat __ssh-helper protocol --completions bashprinted a completion script for the SSH helper alone instead of the full CLI, sobin.fast-path.test.ts > matches the full CLI for helper arguments: completionsfailed on dev and on every PR whose CI runs the server shards.The cause is a merge overlap. #1857 added an
__ssh-helperbranch tobin.tsbacked bycli/sshHelperCli.ts; #1925 then added the fast path (cli/helperMain.ts) ahead of it. After both landed, the old branch was reachable only when the arguments contained an Effect CLI built-in such as--completionsor--help, exactly the casebin.tssays must go to the full CLI. This removes the old branch and its now-unused module, so built-ins fall through to the full CLI as intended.The removed
sshHelperCli.test.tschecked that--versionand the SSH probe answer byte for byte like the full CLI. That check moves into the existing fast-path equality test, which now compares stdout writes as well as console output, covers--versionand__ssh-helper protocol --shell, and refuses a vacuous comparison where the full CLI printed nothing.Validation:
vp test run apps/server/src/bin.fast-path.test.ts: 1 failed / 5 passed on dev (98bd427), 8 passed with this change.vp run check:changed: exit 0 (format, lint, knip, typecheck, 7 test files / 94 tests).Model and harness: claude-opus-5-5 via the Codex harness in GOAT.