Repository navigation
Conversation
Retire acknowledged messages during reconciliation and reject delayed updates for a different environment or thread. Keep blob previews owned by their handoff when a send reports failure after the server has acknowledged it. Upstream: 71ba6b374c0b0181130c0cc3b3d5aaa3387ada67 (#25710)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acknowledged optimistic messages remained in local state until a timer ran, while delayed send updates could reach a different thread. A send failure after acknowledgement could also revoke the blob preview still displayed by the server's message.
71ba6b374c0b0181130c0cc3b3d5aaa3387ada67GOAT adjustments
Rename residue
git show 71ba6b374c | rg '^\+.*\b[Tt]3'lists three added imports of@t3tools/contracts:chat/optimisticUserMessages.test.ts@goat/contracts;package-scoperule inscripts/lib/goat-rename/rules.ts.chat/optimisticUserMessages.ts@goat/contracts; same rule.chat/useAttachmentPreviewHandoff.ts@goat/contracts; same rule.No T3 identifiers were kept and no upstream commit was left out.
Verification
vp fmt apps/web/src/components/ChatView.logic.ts apps/web/src/components/ChatView.tsx apps/web/src/components/chat/optimisticUserMessages.ts apps/web/src/components/chat/optimisticUserMessages.test.ts apps/web/src/components/chat/useAttachmentPreviewHandoff.ts apps/web/src/components/chat/useComposerSend.ts— exit 0, six files.node scripts/goat-rename.ts --check— exit 0:0 lines with T3 residue in 0 files, 0 dropped paths.git diff --checkandgit diff --cached --check— exit 0.NOT RUN:
vp test run apps/web/src/components/ChatView.logic.test.ts apps/web/src/components/chat/optimisticUserMessages.test.ts(including red/green regression proof),vp run check:changed,vp run typecheck, vitest, builds, server suites, and lockf-wrapped runs, per the task's explicit no-local-suites override. Browser captures, real-client verification, and native mobile verification are unavailable on this machine. goat-ci is the verification gate; this lane does not wait for CI, request reviews, watch, or merge.Model: gpt-6.1-sol via GOAT delegated task (Codex harness)