Skip to content

fix(server): hide Android discovery warnings without an SDK (chase 261028 B33) - #1885

Merged
lidge-jun merged 3 commits into
devfrom
chase/261028-b33-android-discovery-warnings
Oct 27, 2026
Merged

lidge-jun merged 3 commits into
devfrom
chase/261028-b33-android-discovery-warnings

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Macs without an Android SDK show an avdmanager discovery warning even though the host summary already explains that Android is unavailable. Suppress the hub's Android probe warnings on those hosts while preserving unrelated iOS warnings and Android discovery failures when Android is available.

Upstream commit Upstream PR Decision What GOAT got
6bbb2d85080d1c824e8c39a883f0f96122304b9a pingdotgg/t3code#25815 take (git cherry-pick -x) Check Android availability before filtering hub warnings; regression coverage for absent and available SDK states.

GOAT adjustments:

  • Cherry-picked cleanly, retaining the shared local/SSH host path and existing CoreSimulator missing-plist suppression. Web, desktop, mobile and agent callers receive the same server result; no client or wire changes.
  • Regenerated the code-budget baseline with node oxlint-plugin-goat/update-code-budgets.ts --init and retained only the DeviceService.test.ts entry, 1151 → 1167 lines. All 16 added lines come from upstream, as allowed by the fork delta's upstream-import policy.
  • Ran node scripts/goat-rename.ts --apply and formatted the changed files. Reverted the script's unrelated sample-fixture rewrites; no unrelated changes are included.

Rename residue:

  • Added T3 names: none. git show 6bbb2d8508 | rg '^\+.*\b[Tt]3' returned no matches (rg exit 1). There are no names to rename, exclude, or retain.
  • node scripts/goat-rename.ts --check: exit 0; 0 lines of residue, 0 affected files, 0 dropped paths.

Verification:

  • RED: applied only upstream's test patch to the base implementation, then ran lockf -k /tmp/goat-heavy-check.lock vp test run apps/server/src/device/DeviceService.test.ts -t 'hides Android discovery failures when the host has no Android SDK'. Exit 1, the selected regression failed because the result included the avdmanager warning instead of only iOS discovery failed. (29 unselected tests skipped).
  • GREEN: lockf -k /tmp/goat-heavy-check.lock vp test run apps/server/src/device/DeviceService.test.ts apps/server/src/device/DeviceClose.test.ts apps/server/src/device/DeviceMultiHost.test.ts: exit 0; 3 files, 32 tests passed, no skips or failures. This also covers retained iOS warnings, SDK availability changes, and local/SSH AVD enumeration failures and recovery.
  • lockf -k /tmp/goat-heavy-check.lock vp run check:changed: exit 0; format, lint, both knip passes, GraphQL generation, affected typechecking (server, scripts and oxlint plugin), and the same 32 focused tests passed. Typechecking reports advisory Effect suggestions without errors.
  • vp env exec node -v: v26.12.1.
  • git diff origin/dev...HEAD --check: exit 0.

CI on head 55ae8d997e839f275b38adca29ebde4b92b0ea05: goat-typecheck, goat-test-changed, goat-scope and the screenshot gate passed. The CI run failed goat-check with one error: goat/code-budget at apps/server/src/cua/ComputerUseLeases.ts:17 (1002 lines, limit 1000). This file is untouched by B33 and has 993 lines on this branch. Newer origin/dev c6c9655b3dc03de1d9bd3e020eb097f2fd622be6 has 1002 lines and no budget entry. Focused vp lint on a temporary copy of that exact dev blob reproduced the same line-budget error (exit 1). The inherited CI failure is left for the lane owning those dev changes; this lane does not watch or merge.

NOT RUN: full repository suites, build, manual device/UI verification, or a full CI dispatch. This is a server-only warning filter; no dev server was started. Reviews and merging are outside this lane.

Model: gpt-6.1-sol via GOAT delegated task (Codex harness)

t3dotgg and others added 2 commits October 28, 2026 01:42
… warnings (#25815)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6bbb2d85080d1c824e8c39a883f0f96122304b9a)
@lidge-jun lidge-jun closed this Oct 27, 2026
@lidge-jun lidge-jun reopened this Oct 27, 2026
@lidge-jun
lidge-jun merged commit d009549 into dev Oct 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants