Repository navigation
fix(server): hide Android discovery warnings without an SDK (chase 261028 B33) - #1885
Merged
Merged
Conversation
… warnings (#25815) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6bbb2d85080d1c824e8c39a883f0f96122304b9a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macs without an Android SDK show an avdmanager discovery warning even though the host summary already explains that Android is unavailable. Suppress the hub's Android probe warnings on those hosts while preserving unrelated iOS warnings and Android discovery failures when Android is available.
6bbb2d85080d1c824e8c39a883f0f96122304b9agit cherry-pick -x)GOAT adjustments:
node oxlint-plugin-goat/update-code-budgets.ts --initand retained only theDeviceService.test.tsentry, 1151 → 1167 lines. All 16 added lines come from upstream, as allowed by the fork delta's upstream-import policy.node scripts/goat-rename.ts --applyand formatted the changed files. Reverted the script's unrelated sample-fixture rewrites; no unrelated changes are included.Rename residue:
git show 6bbb2d8508 | rg '^\+.*\b[Tt]3'returned no matches (rg exit 1). There are no names to rename, exclude, or retain.node scripts/goat-rename.ts --check: exit 0; 0 lines of residue, 0 affected files, 0 dropped paths.Verification:
lockf -k /tmp/goat-heavy-check.lock vp test run apps/server/src/device/DeviceService.test.ts -t 'hides Android discovery failures when the host has no Android SDK'. Exit 1, the selected regression failed because the result included the avdmanager warning instead of onlyiOS discovery failed.(29 unselected tests skipped).lockf -k /tmp/goat-heavy-check.lock vp test run apps/server/src/device/DeviceService.test.ts apps/server/src/device/DeviceClose.test.ts apps/server/src/device/DeviceMultiHost.test.ts: exit 0; 3 files, 32 tests passed, no skips or failures. This also covers retained iOS warnings, SDK availability changes, and local/SSH AVD enumeration failures and recovery.lockf -k /tmp/goat-heavy-check.lock vp run check:changed: exit 0; format, lint, both knip passes, GraphQL generation, affected typechecking (server, scripts and oxlint plugin), and the same 32 focused tests passed. Typechecking reports advisory Effect suggestions without errors.vp env exec node -v:v26.12.1.git diff origin/dev...HEAD --check: exit 0.CI on head
55ae8d997e839f275b38adca29ebde4b92b0ea05:goat-typecheck,goat-test-changed,goat-scopeand the screenshot gate passed. The CI run failedgoat-checkwith one error:goat/code-budgetatapps/server/src/cua/ComputerUseLeases.ts:17(1002 lines, limit 1000). This file is untouched by B33 and has 993 lines on this branch. Newerorigin/devc6c9655b3dc03de1d9bd3e020eb097f2fd622be6has 1002 lines and no budget entry. Focusedvp linton a temporary copy of that exact dev blob reproduced the same line-budget error (exit 1). The inherited CI failure is left for the lane owning those dev changes; this lane does not watch or merge.NOT RUN: full repository suites, build, manual device/UI verification, or a full CI dispatch. This is a server-only warning filter; no dev server was started. Reviews and merging are outside this lane.
Model: gpt-6.1-sol via GOAT delegated task (Codex harness)