Repository navigation
fix(shared): pin managed cloudflared to 2026.10.4 (chase 261028 B04) - #1880
Merged
Merged
Conversation
… compromised eMudhra intermediates (#25572) Co-authored-by: Theo Browne <me@t3.gg> (cherry picked from commit b6994c549977dd194d38f95902fcfac0445d8fa1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOAT's managed relay client still downloads cloudflared 2026.10.0. Take upstream's security-motivated 2026.10.4 pin and update every platform URL and SHA-256 together.
b6994c549977dd194d38f95902fcfac0445d8fa1git cherry-pick -x)GOAT adjustments:
GOAT_CLOUDFLARED_PATH, the existing managed installer, and Windows ARM64's x64 asset selection.Hash provenance: a fresh comparison against Cloudflare's GitHub release asset metadata matched all six manifest entries. The macOS hashes in the release description differ from its asset metadata; the pin follows the asset digests, as upstream does.
Rename residue:
git show b6994c5499 --format= -- | rg '^\+.*\b[Tt]3': no added T3 names (no matches, exit 1). There are no added names to rename, exclude, or retain.node scripts/goat-rename.ts --applyran; unrelated baseline fixture rewrites were restored. GOAT identity remains intact without a rename-rule change.node scripts/goat-rename.ts --check: exit 0, zero residue lines and zero dropped paths.Verification:
vp env exec node -v: v26.12.1.vp test run packages/shared/src/relayClient.test.ts -t '2026.10.4 release'before the cherry-pick: all six platform cases failed withinvalid_checksumagainst the old manifest.vp test run packages/shared/src/relayClient.test.ts: 21 passed, zero failures or skips.lockf -k /tmp/goat-heavy-check.lock vp test run packages/shared/src/relayClient.test.ts apps/server/src/cloud/ManagedEndpointRuntime.test.ts apps/server/src/cli/connect.test.ts: 3 files, 38 tests passed, zero failures or skips.lockf -k /tmp/goat-heavy-check.lock vp run check:changed: exit 0. Format, lint, both knip passes, all 32 affected package typechecks, and 5 test files / 55 tests passed. The complete log contains compiler suggestions, with no error or warning diagnostics.gh api repos/cloudflare/cloudflared/releases/tags/2026.10.4plus a Python comparison against the manifest: all six target entries matched the five distinct asset digests; minimum version remains 2025.6.1.vp env exec node --input-type=modulefrompackages/shared, invokingRelayClient.installwith Node services and FetchHttpClient in a scoped temporary home on macOS ARM64. Real download, SHA-256 verification, extraction, version validation, activation, and resolution passed: installed and resolved sourcemanaged, version2026.10.4. The temporary home was removed.git diff --check origin/dev...HEAD: exit 0.NOT RUN: native installs/execution on macOS x64, Linux, and Windows; live relay tunnel or client UI; full repository suites, build, or release smoke; CI completion, independent review, or merge (integration lane owns those).
Model: gpt-6.1-sol via GOAT delegated task (Codex harness)