This repository has been archived by the owner on Jun 14, 2019. It is now read-only.
Fix empty IN/NOT IN conditions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
May 19, 2017
| return err | ||
| } | ||
| return nil | ||
| _, err := fmt.Fprint(w, "0=0") |
There was a problem hiding this comment.
why not "1=0"? consider x.NotIn("id", []int64{}).Delete(new(User))
There was a problem hiding this comment.
Wouldn't your example delete all users (i.e. every user whose id is not in the empty list)? So we would want "0=0", not "1=0".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For empty
INclauses, xorm generates SQL of the form<col> IN ()(similarly forNOT IN). This is not accepted by either MySQL or PostgreSQL, and might as well be replaced with false (0=1) and true (0=0) conditions, respectively