Fix and test for delete user #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why rename models/consistency_test.go → models/consistency.go ? |
tboerger
added
the
lgtm/need 2
|
@sapk So that it can be used in |
lafriks
reviewed
May 12, 2017
models/user.go
Outdated
| @@ -945,13 +945,23 @@ func deleteUser(e *xorm.Session, u *User) error { | |||
| // ***** END: Star ***** | |||
|
|
|||
| // ***** START: Follow ***** | |||
| followees := make([]*Follow, 0, 10) | |||
There was a problem hiding this comment.
Maybe this could be changed to []int64 array and select only FollowID values into this array. I don't know what is the limitation of count for In(field, array) but it could be optimized to update it in batches so that there would be less requests to database
There was a problem hiding this comment.
@lafriks I have an updated version, but it's blocked on a fix to xorm (go-xorm/builder#4)
There was a problem hiding this comment.
@ethantkoenig fix seems to be merged in xorm, you can now fetch dependency and it should be ok now
lafriks
reviewed
May 12, 2017
models/user.go
Outdated
| return fmt.Errorf("decrease user follower number[%d]: %v", followees[i].FollowID, err) | ||
| } | ||
| } | ||
|
|
||
| followers := make([]*Follow, 0, 10) |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where
num_followingfields were not correctly updated on user delete.Also add an integration test for deleting users.