Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpbakery: ensure no read after DoWithBody #98

Merged
merged 1 commit into from
May 3, 2016
Merged

httpbakery: ensure no read after DoWithBody #98

merged 1 commit into from
May 3, 2016

Commits on May 3, 2016

  1. httpbakery: ensure no read after DoWithBody 

    This juju bug https://bugs.launchpad.net/juju-core/+bug/1576509
shows that reading after a request has returned, which
http.Client.Do can (see Go issue #12796) is a problem.

Ensure that DoWithBody can never do that by closing
the existing readStopper body which is in place for
just that reason.
    @rogpeppe
    rogpeppe committed May 3, 2016
    Configuration menu
    Copy the full SHA
    ef918cf View commit details
    Browse the repository at this point in the history