httpbakery: ensure no read after DoWithBody #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This juju bug https://bugs.launchpad.net/juju-core/+bug/1576509 shows that reading after a request has returned, which http.Client.Do can (see Go issue #12796) is a problem. Ensure that DoWithBody can never do that by closing the existing readStopper body which is in place for just that reason.
|
LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This juju bug https://bugs.launchpad.net/juju-core/+bug/1576509
shows that reading after a request has returned, which
http.Client.Do can (see Go issue golang/go#12796) is a problem.
Ensure that DoWithBody can never do that by closing
the existing readStopper body which is in place for
just that reason.