Avoid using temp file during write #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI build passed for all Go versions 1.5+, failed for Go 1.4 with the following: This seems to suggest that the |
|
Thanks your PR! I think the problem is Go 1.4, I saw goconvey supports from 1.2.x. Just a small change on CI config file, I'll do that after merge this PR. |
|
Hmm... CI is still failing. Anyway I'll remove Go 1.4 from CI file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slight refactoring to avoid writing/renaming a temp file when writing a ini file. Using a temp file is problematic if the file you are writing to is mounted inside a Docker container (see go-gitea/gitea#2197).