-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily patch go-ini/ini with fork #2255
Conversation
Why not updating vendor to migrate to a temporary fork if the issue take to much time?(https://github.com/kardianos/govendor/blob/master/doc/faq.md#q-ive-forked-a-package-and-i-havent-upstreamed-the-changes-yet-what-should-i-do) |
3024567
to
2b45cdb
Compare
I think that go-ini/ini fork with that change should be moved under gitea org |
@lafriks Done |
2b45cdb
to
84534a6
Compare
LGTM |
LGTM |
A short-term fix for #2197.Fixing the underlying problem will involve changing theSaveTo(..)
method in thego-ini/ini
package, but this will at leastLet Docker users run gitea in the meantimeMitigate the problem enough to not block the 1.2.0 releaseFixes #2197. Updates the
SaveTo(..)
method in thego-ini/ini
package. For the sake of not blocking the 1.2.0 release, I've temporarily updated the dependency to a fork. Once the fix to theSaveTo(..)
method is merged into the main repository (go-ini/ini#115), we can revert.