Skip to content

Fix review submission from single-commit PR view#37475

Merged
wxiaoguang merged 3 commits intogo-gitea:mainfrom
cyphercodes:fix-pr-review-submit-single-commit
Apr 29, 2026
Merged

Fix review submission from single-commit PR view#37475
wxiaoguang merged 3 commits intogo-gitea:mainfrom
cyphercodes:fix-pr-review-submit-single-commit

Conversation

@cyphercodes
Copy link
Copy Markdown
Contributor

@cyphercodes cyphercodes commented Apr 28, 2026

Fixes #37415.

Pin the review submission form action to the canonical PR files route

Use the PR files view as the canonical review submission target so the review modal does not post to an unrouted single-commit URL.

Co-authored-by: Hermes Agent (OpenAI GPT-5.5) <noreply@nousresearch.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2026
@wxiaoguang wxiaoguang added backport/v1.26 This PR should be backported to Gitea 1.26 type/bug labels Apr 29, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2026
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 29, 2026 16:42
@wxiaoguang wxiaoguang merged commit 184ce17 into go-gitea:main Apr 29, 2026
28 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone Apr 29, 2026
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 29, 2026
bircni pushed a commit that referenced this pull request Apr 29, 2026
Backport #37475 by @cyphercodes

Fixes #37415.

Pin the review submission form action to the canonical PR files route

Co-authored-by: Rayan Salhab <r.salhab@aiyexpertsolutions.com>
Co-authored-by: cyphercodes <cyphercodes@users.noreply.github.com>
Co-authored-by: Hermes Agent (OpenAI GPT-5.5) <noreply@nousresearch.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 30, 2026
* origin/main:
  Refactor CI workflows (go-gitea#37487)
  Allow multiple projects per issue and pull requests (go-gitea#36784)
  [skip ci] Updated translations via Crowdin
  Refactor compare diff/pull page (1) (go-gitea#37481)
  Fix review submission from single-commit PR view (go-gitea#37475)
  Refactor integration tests infrastructure (go-gitea#37462)
  Fix allow maintainer edit permission check (go-gitea#37479)
  Serve OpenAPI 3.0 spec at /openapi.v1.json (go-gitea#37038)
  Batch-load related data in actions run, job, and task API endpoints (go-gitea#37032)
  Add DEFAULT_TITLE_SOURCE setting for pull request title default behavior (go-gitea#37465)
  Fix compare dropdown for branches without common history (go-gitea#37470)
  FIX: URL sanitization to handle schemeless credentials (go-gitea#37440)
  Refactor pull request view (4) (go-gitea#37451)

# Conflicts:
#	modules/indexer/issues/elasticsearch/elasticsearch.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.26 This PR should be backported to Gitea 1.26 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submit review returns 404 from single-commit view of a PR (/pulls/{idx}/commits/{sha})

4 participants