Batch-load related data in actions run, job, and task API endpoints by myers · Pull Request #37032 · go-gitea/gitea

myers · 2026-03-29T17:58:04Z

Avoid per-item DB queries in ListRuns, ListJobs, and ListActionTasks by batch-loading trigger users, repositories, and task attributes before the conversion loop. Remove ReferencesGitRepo from the /actions route group since no task/run endpoints use it.

I ran into this in another fork that will remain nameless, their action page wouldn't load for me.

Added tests for these endpoints as well.

This was built using Claude Code with Opus.

Copilot

Pull request overview

This PR optimizes GitHub Actions API list endpoints by reducing per-item database queries through batch-loading related models (repos, trigger users, job/task attributes) before converting results to API structs, and adjusts routing middleware accordingly.

Changes:

Batch-load run trigger users and repositories in ListRuns, and job run/repo references in ListJobs.
Batch-load task/job/run references in ListActionTasks.
Remove context.ReferencesGitRepo(true) from the repo /actions route group and add integration tests for user-level run/job listing.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
tests/integration/api_actions_run_test.go	Adds integration coverage for `/api/v1/user/actions/runs` and `/api/v1/user/actions/jobs` responses.
routers/api/v1/shared/action.go	Batch-loads runs/jobs dependencies to avoid per-item repo/user queries in shared listing helpers.
routers/api/v1/repo/action.go	Batch-loads task attributes prior to conversion in repo task listing endpoint.
routers/api/v1/api.go	Removes Git repo reference middleware from repo `/actions` API routes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ToActionWorkflowRun and ToActionTask both call LoadAttributes unconditionally, which re-queries repos and loads unused task steps even when the list handler has already batch-loaded everything. Guard both with a nil check on the already-populated field: skip LoadAttributes when TriggerUser (runs) or Job (tasks) is set.

myers · 2026-03-29T21:34:21Z

Sorry about the force push. I forced a squashed fix, then again to unsquash it.

silverwind · 2026-03-30T08:49:30Z

Please click "Resolve conversation" on all addressed comments so we know what is still pending.

Add ActionTask.LoadJobAttributes that loads Job and its attributes (Run, Repo) without loading Steps. Use it in ToActionTask so the task list endpoint no longer issues per-task step queries. Co-Authored-By: Claude (Opus)

Assign the already-available repo parameter to run.Repo so LoadAttributes skips the redundant repo lookup, and remove the TriggerUser nil guard since LoadAttributes handles nil checks internally. Co-Authored-By: Claude (Opus)

…x/actions-api-n-plus-1 # Conflicts: # services/convert/convert.go

If a job references a run that was deleted between the job query and the run query, the map lookup returns nil and the next line panics. Nil-check before setting j.Run.Repo. Co-Authored-By: Claude <noreply@anthropic.com> (claude-opus-4-7)

This branch indicates server-side data inconsistency (the batch loader couldn't resolve the run or repo for a job we just listed), not a missing resource the client asked for. APIErrorInternal returns 500 and logs the error detail server-side instead of echoing the job ID in the response body. Co-Authored-By: Claude <noreply@anthropic.com> (claude-opus-4-7)

myers · 2026-04-19T21:00:09Z

@silverwind

Thanks for the review.

Finding 1 (wrong HTTP status in ListJobs): Fixed in 096ad618c8. Now returns 500 via APIErrorInternal(fmt.Errorf(...)) — the job ID stays in the server-side log but isn't echoed in the response body. Also pushed 79afaec19a defensively: ActionJobList.LoadRuns can leave j.Run nil if a run row is missing, so guarded j.Run.Repo = j.Repo against the nil case.

Finding 2 (Repository.APIURL semantics change): This change came in with bc61edad ("fix more") from @wxiaoguang during his review-pass on this branch, not the original PR. The observation is accurate — under PUBLIC_URL_DETECTION=auto, ~43 call sites will now return request-host-derived URLs instead of the configured AppURL. I don't think it should block this PR (it's a maintainer-initiated change), but happy to note it in the PR description, and wxiaoguang may want to weigh in on whether it belongs here or in a follow-up.

Comment authored by Claude.

When isRepoLevel, ctx.Repo.Repository (with Owner populated by middleware) is already assigned to every run, so the subsequent LoadRepos + LoadOwners queries are redundant and overwrite the pre-assigned pointers. Add a repo-level ListRuns integration test covering the branch. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-04-19T21:34:40Z

Remaining findings fixed in 8da8495.

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* origin/main: Refactor CI workflows (go-gitea#37487) Allow multiple projects per issue and pull requests (go-gitea#36784) [skip ci] Updated translations via Crowdin Refactor compare diff/pull page (1) (go-gitea#37481) Fix review submission from single-commit PR view (go-gitea#37475) Refactor integration tests infrastructure (go-gitea#37462) Fix allow maintainer edit permission check (go-gitea#37479) Serve OpenAPI 3.0 spec at /openapi.v1.json (go-gitea#37038) Batch-load related data in actions run, job, and task API endpoints (go-gitea#37032) Add DEFAULT_TITLE_SOURCE setting for pull request title default behavior (go-gitea#37465) Fix compare dropdown for branches without common history (go-gitea#37470) FIX: URL sanitization to handle schemeless credentials (go-gitea#37440) Refactor pull request view (4) (go-gitea#37451) # Conflicts: # modules/indexer/issues/elasticsearch/elasticsearch.go

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2026

github-actions Bot added modifies/api labels Mar 29, 2026

myers force-pushed the fix/actions-api-n-plus-1 branch from 15f60ab to 88787d9 Compare March 29, 2026 18:11

silverwind requested a review from Copilot March 29, 2026 18:52

Copilot started reviewing on behalf of silverwind March 29, 2026 18:53 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Comment thread routers/api/v1/shared/action.go

Comment thread routers/api/v1/shared/action.go

Comment thread routers/api/v1/shared/action.go

Comment thread routers/api/v1/repo/action.go

wxiaoguang reviewed Mar 29, 2026

View reviewed changes

Comment thread tests/integration/api_actions_run_test.go Outdated

myers force-pushed the fix/actions-api-n-plus-1 branch 3 times, most recently from b729742 to 7a87efe Compare March 29, 2026 20:59

myers added 2 commits March 29, 2026 21:04

Batch-load related data in actions run, job, and task API endpoints

28044de

myers force-pushed the fix/actions-api-n-plus-1 branch from 7a87efe to 4c02528 Compare March 29, 2026 21:05

wxiaoguang reviewed Mar 30, 2026

View reviewed changes

Comment thread services/convert/convert.go Outdated

Add LoadJobAttributes to avoid loading steps in list endpoints

0b1ed61

Add ActionTask.LoadJobAttributes that loads Job and its attributes (Run, Repo) without loading Steps. Use it in ToActionTask so the task list endpoint no longer issues per-task step queries. Co-Authored-By: Claude (Opus)

myers requested a review from wxiaoguang April 12, 2026 01:24

lunny reviewed Apr 12, 2026

View reviewed changes

Comment thread routers/api/v1/api.go

wxiaoguang reviewed Apr 12, 2026

View reviewed changes

Comment thread services/convert/convert.go Outdated

wxiaoguang and others added 8 commits April 12, 2026 10:43

remove over-defensive code

1ad4af2

fix wrong response, fix wrong link

6f96faf

fix more

fab9df3

fix

8664e1e

merge tests

809649e

Set run.Repo before LoadAttributes in ToActionWorkflowRun

d3292f3

Assign the already-available repo parameter to run.Repo so LoadAttributes skips the redundant repo lookup, and remove the TriggerUser nil guard since LoadAttributes handles nil checks internally. Co-Authored-By: Claude (Opus)

Merge remote-tracking branch 'origin/main' into fix/actions-api-n-plus-1

7001ad1

Merge remote-tracking branch 'myers/fix/actions-api-n-plus-1' into fi…

4cd9fe9

…x/actions-api-n-plus-1 # Conflicts: # services/convert/convert.go

wxiaoguang previously approved these changes Apr 12, 2026

View reviewed changes

lunny removed modifies/api labels Apr 19, 2026

myers added 2 commits April 19, 2026 20:49

silverwind and others added 2 commits April 19, 2026 23:18

Merge branch 'main' into fix/actions-api-n-plus-1

b681623

silverwind approved these changes Apr 19, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2026

lunny added the performance/speed performance issues with slow downs label Apr 19, 2026

lunny added this to the 1.27.0 milestone Apr 19, 2026

wxiaoguang added 3 commits April 29, 2026 14:54

Merge branch 'main' into fix/actions-api-n-plus-1

1b87e0d

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

fix merge

09e720b

fix

ff137f4

wxiaoguang approved these changes Apr 29, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2026

wxiaoguang added 2 commits April 29, 2026 15:43

fix

fb0161a

fix

285deba

wxiaoguang requested a review from Copilot April 29, 2026 08:02

Copilot started reviewing on behalf of wxiaoguang April 29, 2026 08:02 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread services/convert/convert.go Outdated

Comment thread services/convert/convert.go

wxiaoguang added 2 commits April 29, 2026 16:14

fix

838ba0f

clean up

bebf60a

wxiaoguang enabled auto-merge (squash) April 29, 2026 08:20

wxiaoguang merged commit 18762c7 into go-gitea:main Apr 29, 2026
26 checks passed

lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Batch-load related data in actions run, job, and task API endpoints#37032

Batch-load related data in actions run, job, and task API endpoints#37032
wxiaoguang merged 25 commits intogo-gitea:mainfrom
myers:fix/actions-api-n-plus-1

myers commented Mar 29, 2026 •

edited by lunny

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

myers commented Mar 29, 2026

Uh oh!

Uh oh!

silverwind commented Mar 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

myers commented Apr 19, 2026

Uh oh!

silverwind commented Apr 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

myers commented Mar 29, 2026 • edited by lunny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

myers commented Mar 29, 2026

Uh oh!

Uh oh!

silverwind commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

myers commented Apr 19, 2026

Uh oh!

silverwind commented Apr 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

myers commented Mar 29, 2026 •

edited by lunny

Loading

silverwind commented Mar 30, 2026 •

edited

Loading