Fix fetch action redirect

[wxiaoguang]

And add tests for its behavior

[silverwind]

Not sure if this changes anything but keep note that redirect behaviour can be controlled in fetch via https://developer.mozilla.org/en-US/docs/Web/API/Request/redirect.

const resp = fetch(url, {redirect: 'manual'});
if (resp.type === 'opaqueredirect') {
  console.log("Redirect intercepted manually.");
}

[wxiaoguang]

Not sure if this changes anything but keep note that redirect behaviour can be controlled in fetch via https://developer.mozilla.org/en-US/docs/Web/API/Request/redirect.

Unrelated. I think I have answered such question in the previous PRs, and left enough comments.

[silverwind]

Backport needed?

[wxiaoguang]

Backport needed?

No, it's caused by the htmx removal.

[silverwind]

Test cleanup done in 06e0fb5.

[wxiaoguang]

Why not just call vi.clearAllMocks();?

[silverwind]

Why not just call vi.clearAllMocks();?

vi.resetAllMocks() also wipes the mock implementation, so after the first reset the spies fall through to the real assign/reload. mockClear() keeps the () => {} no-op and just clears call history; mockRestore() at the end puts the originals back.

---

Posted by Claude Opus 4.7 on behalf of @silverwind

[wxiaoguang]

Why not just call vi.clearAllMocks();?

vi.resetAllMocks() also wipes the mock implementation, so after the first reset the spies fall through to the real assign/reload. mockClear() keeps the () => {} no-op and just clears call history; mockRestore() at the end puts the originals back.

Are you SURE?

[wxiaoguang]

Why not just call vi.clearAllMocks();?

vi.resetAllMocks() also wipes the mock implementation, so after the first reset the spies fall through to the real assign/reload. mockClear() keeps the () => {} no-op and just clears call history; mockRestore() at the end puts the originals back.

Posted by Claude Opus 4.7 on behalf of @silverwind

Can you spend more time on thinking about the problem?

If "fall through to the real ", how can the tests pass and succeed?

[silverwind]

vi.clearAllMocks is actually functionally equivalent here, keep it, it's shorter.

[wxiaoguang]

vi.clearAllMocks is actually functionally equivalent here, keep it, it's shorter.

resetAllMocks is also right, teach your AI

[silverwind]

It saw its error, I will add the memory

I jumped from "wipes the implementation" to "test isolation is broken", without actually testing that.