Improve testing init, clean up webhook tests

[Copilot]

Avoid webhook test fixtures affect other tests (be triggered)

Also fixed more testing problems including path init, global config pollution & conflict

[Copilot]

Pull request overview

This PR focuses on making tests more isolated and less fixture-dependent, particularly around webhooks and test environment initialization, and restructures some CLI tests to reduce configuration/global-state conflicts.

Changes:

• Removes webhook/hook task fixture data and updates webhook-related tests to create their own records.
• Adjusts unit/integration tests to avoid relying on existing webhook rows/hook-task counts and to use JSON redirect parsing helpers.
• Refactors CLI test coverage by moving config/path parsing tests into a separate package and exporting a helper used by those tests.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/integration/pull_merge_test.go	Adds explicit webhook setup/assertion helpers and improves redirect/JSON decoding usage in PR merge tests.
services/webhook/webhook_test.go	Reworks webhook service tests to prepare their own webhooks instead of relying on fixtures; groups related cases under one top-level test.
services/webhook/deliver.go	Simplifies default HTTP method handling for webhook delivery.
routers/api/v1/repo/hook_test.go	Inserts a webhook within the test and uses the generated ID instead of a fixture ID.
modules/setting/testenv.go	Changes test env config initialization to write config content into the test config file.
models/webhook/webhook_test.go	Reworks webhook model tests to rely on package setup data rather than fixture IDs.
models/webhook/webhook_system_test.go	Updates expectations to use loaded beans instead of fixed IDs and switches some assertions to require.
models/webhook/main_test.go	Adds a package-level SetUp hook to populate webhook test data.
models/unittest/testdb.go	Changes test init to configure APP_DATA_PATH via generated config content before SetupGiteaTestEnv.
models/fixtures/webhook.yml	Replaces webhook fixtures with an empty list and guidance comment.
models/fixtures/hook_task.yml	Replaces hook task fixtures with an empty list and guidance comment.
cmd/main_test.go	Replaces prior CLI/config tests with a focused default-command validation test.
cmd/main.go	Exports the global-flag preparation helper and updates internal usage.
cmd/helper.go	Adds shared CLI helper functions (extracted/centralized logic).
cmd/cmdtest/cmd_test.go	Adds a separate-package CLI test suite that exercises config/path parsing behaviors.
cmd/cmd_test.go	Removes the old default-command test file (moved/merged into cmd/main_test.go).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 13 comments.

Comments suppressed due to low confidence (1)

modules/setting/testenv.go:69

• initGiteaConf builds CustomConf using the current AppWorkPath, but AppWorkPath is still the test-binary directory at this point (and you no longer override it to the source root). When GITEA_TEST_CONF is a relative path like tests/sqlite.ini, this will resolve to a non-existent file and tests may run with an empty config. Consider resolving relative GITEA_TEST_CONF against *giteaTestSourceRoot (or set the test work path before computing CustomConf).

	initGiteaConf := func() string {
		// giteaConf (GITEA_CONF) must be relative because it is used in the git hooks as "$GITEA_ROOT/$GITEA_CONF"
		giteaConf := os.Getenv("GITEA_TEST_CONF")
		if giteaConf == "" {
			// if no GITEA_TEST_CONF, then it is in unit test, use a temp (non-existing / empty) config file
			// do not really use such config file, the test can run concurrently, using the same config file will cause data-race between tests
			giteaConf = "custom/conf/app-test-tmp.ini"
			customConfBuiltin = filepath.Join(AppWorkPath, giteaConf)
			CustomConf = customConfBuiltin
			_ = os.Remove(CustomConf)
		} else {
			// CustomConf must be absolute path to make tests pass,
			CustomConf = filepath.Join(AppWorkPath, giteaConf)
		}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.