Skip to content

Stabilise e2e logout propagation test (backport #37403) #37404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind wants to merge 1 commit into from
+5 −1
Closed

Stabilise e2e logout propagation test (backport #37403) #37404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/e2e/events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,12 @@ test.describe('events', () => {

await loginUser(page1, name);

// Navigate page2 so it connects to the shared event stream
// Navigate page2 so it connects to the shared event stream, and wait for the
// SSE response to start — otherwise the logout event can race the connection
// and be silently dropped when no messenger is registered yet for the user.
const eventsResponse = page2.waitForResponse((r) => r.url().includes('/user/events'));
await page2.goto('/');
await eventsResponse;

// Verify page2 is logged in
await expect(page2.getByRole('link', {name: 'Sign In'})).toBeHidden();
Expand Down