Stabilise e2e logout propagation test (backport #37403)#37404
Closed
silverwind wants to merge 1 commit intogo-gitea:release/v1.26from
Closed
Stabilise e2e logout propagation test (backport #37403)#37404silverwind wants to merge 1 commit intogo-gitea:release/v1.26from
silverwind wants to merge 1 commit intogo-gitea:release/v1.26from
Conversation
Wait for page2's `/user/events` SSE response before triggering logout on page1. Without this, the shared worker's EventSource may not have registered a messenger on the server yet when `SignOut` calls `SendMessageBlocking`, causing the logout event to be silently dropped and page2 to never redirect. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
changed the title
silverwind
added
type/testing
skip-changelog
Member
Author
|
Actually this cherry-picks cleanly so we can use giteabot to do it. |
silverwind
changed the title
silverwind
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37403 to
release/v1.26.The
events › logout propagatione2e test was racing the SSE connection setup: if page2's SharedWorker had not finished registering its messenger by the time page1 triggered logout, the event was silently dropped and page2 stayed on the authenticated page.Wait 500ms after verifying page2 is signed in, before triggering the logout from page1, so the SharedWorker has time to register. Comment points at a cleaner future fix (expose a ready attribute on the page) that will also work for the planned WebSocket SharedWorker.
This PR was written with the help of Claude Opus 4.7