Skip to content

Drop Fomantic tab, checkbox and form patches#37377

Merged
wxiaoguang merged 11 commits intogo-gitea:mainfrom
silverwind:fomjs
Apr 24, 2026
Merged

Drop Fomantic tab, checkbox and form patches#37377
wxiaoguang merged 11 commits intogo-gitea:mainfrom
silverwind:fomjs

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Apr 23, 2026 •
edited
Loading

Clean up the fomantic helpers that nothing inside fomantic depends on. Manually tested all functionality.

This PR was written with the help of Claude Opus 4.7

@silverwind @claude
Move Fomantic tab and aria-label patches to first-party JS; wrap moda…
1d2a54c 
…l API

Replaces the deleted `fomantic/checkbox.ts`, `fomantic/form.ts`, and
`fomantic/tab.ts` with three small shared modules:

- `modules/tab.ts` — first-party `initTabs`, no jQuery/Fomantic
- `modules/aria.ts` — first-party `initAriaLabels`, no jQuery/Fomantic
- `modules/modal.ts` — `showModal` / `hideModal` API facade; still
  delegates to the Fomantic modal plugin internally so callers no
  longer touch jQuery

All affected call sites migrated off direct `fomanticQuery(...).modal(...)`
and `.tab()` usage. Devtest gets `tabs.tmpl` / `aria-labels.tmpl` fixtures
and modal-option variants (closable:false, onApprove→false, onShow).

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 23, 2026
silverwind and others added 2 commits April 23, 2026 03:36
@silverwind @claude
Remove devtest additions
71c32c7 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind @claude
Move new modules into web_src/js/modules/fomantic/
61dafb7 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind silverwind changed the title Move Fomantic tab and aria-label patches to first-party JS; wrap modal API Drop Fomantic tab and checkbox/form-field patches Apr 23, 2026
@silverwind silverwind changed the title Drop Fomantic tab and checkbox/form-field patches Drop Fomantic tab, checkbox and form patches Apr 23, 2026
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 23, 2026
@silverwind @claude
Reword initTabs comment
a072c55 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
wxiaoguang
wxiaoguang reviewed Apr 23, 2026
View reviewed changes
Comment thread web_src/js/features/admin/common.ts Outdated
silverwind and others added 2 commits April 23, 2026 11:37
@silverwind @claude
Rename showModal/hideModal to showFomanticModal/hideFomanticModal
f75c7ba 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind @claude
Move aria label patches back into base.ts
70fab26 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2026
wxiaoguang
wxiaoguang approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all pages with changes made by me

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2026
@wxiaoguang wxiaoguang merged commit 3816210 into go-gitea:main Apr 24, 2026
26 checks passed
@wxiaoguang wxiaoguang deleted the fomjs branch April 24, 2026 08:02
@GiteaBot GiteaBot added this to the 1.27.0 milestone Apr 24, 2026
silverwind added a commit to mohammad-rj/gitea that referenced this pull request Apr 24, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into feat/websocket-migration
ec54754 
* origin/main: (127 commits)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
  fix: dump with default zip type produces uncompressed zip (go-gitea#37401)
  Allow fast-forward-only merge when signed commits are required (go-gitea#37335)
  Introduce `ActionRunAttempt` to represent each execution of a run (go-gitea#37119)
  Move review request functions to a standalone file (go-gitea#37358)
  Fix repo init README EOL (go-gitea#37388)
  Fix org team assignee/reviewer lookups for team member permissions (go-gitea#37365)
  Remove external service dependencies in migration tests (go-gitea#36866)
  Extend issue context popup beyond markdown content (go-gitea#36908)
  fix: commit status reporting (go-gitea#37372)
  Support for Custom URI Schemes in OAuth2 Redirect URIs (go-gitea#37356)
  Fix cmd tests by mocking builtin paths (go-gitea#37369)
  chore: upgrade Go version in devcontainer image to 1.26 (go-gitea#37374)
  Fix button layout shift when collapsing file tree in editor (go-gitea#37363)
  Update `Block a user` form (go-gitea#37359)
  Remove IsValidExternalURL/IsAPIURL and use IsValidURL at call sites (go-gitea#37364)
  ...

# Conflicts:
#	modules/eventsource/event.go
#	tests/e2e/events.test.ts
silverwind added a commit to TheFox0x7/gitea that referenced this pull request Apr 24, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into pr-37105-modernrc-sqlite
68ebe73 
* origin/main:
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 25, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into reply
aec2f56 
* origin/main: (51 commits)
  Fix color regressions, add `priority` color (go-gitea#37417)
  [skip ci] Updated translations via Crowdin
  Stabilize e2e logout propagation test (go-gitea#37403)
  refactor: serve site manifest via `/assets/site-manifest.json` endpoint (go-gitea#37405)
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
  fix: dump with default zip type produces uncompressed zip (go-gitea#37401)
  Allow fast-forward-only merge when signed commits are required (go-gitea#37335)
  Introduce `ActionRunAttempt` to represent each execution of a run (go-gitea#37119)
  Move review request functions to a standalone file (go-gitea#37358)
  Fix repo init README EOL (go-gitea#37388)
  Fix org team assignee/reviewer lookups for team member permissions (go-gitea#37365)
  Remove external service dependencies in migration tests (go-gitea#36866)
  Extend issue context popup beyond markdown content (go-gitea#36908)
  fix: commit status reporting (go-gitea#37372)
  Support for Custom URI Schemes in OAuth2 Redirect URIs (go-gitea#37356)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @lunny @wxiaoguang @GiteaBot