Skip to content

Remove dead CSS#37376

Merged
denyskon merged 6 commits intogo-gitea:mainfrom
silverwind:remove-dead-fomantic-css
Apr 24, 2026
Merged

Remove dead CSS#37376
denyskon merged 6 commits intogo-gitea:mainfrom
silverwind:remove-dead-fomantic-css

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Apr 22, 2026 •
edited
Loading

Removes CSS rules that have zero usages across templates, Go source, JS/TS/Vue, and options/. Each selector was cross-checked for runtime additions (Fomantic JS, library classes) before removal.

A few rules with no current usages are kept as symmetric pairs of heavily-used classes likely to be needed:

  • .ui.bottom.attached.header / .ui.bottom.attached.message — pair with the widely-used top.attached variants
  • .ui.warning.header / .ui.warning.segment — warning-themed variants of error-themed classes that are kept
  • .btn.small — size variant alongside the kept .btn.tiny

This PR was written with the help of Claude Opus 4.7

@silverwind @claude
Remove dead Fomantic UI CSS and pre-2023 vendor prefixes
ddad67e 
Cross-checked each selector against templates, Go source, JS/TS/Vue
and options/ to confirm zero usages before removal. Also drops
`-webkit-mask-*` prefixes where unprefixed equivalents are present
(Safari 15.4+, March 2022).

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2026
@silverwind silverwind closed this Apr 22, 2026
@silverwind silverwind reopened this Apr 23, 2026
@silverwind silverwind requested a review from Copilot April 23, 2026 00:40
Copilot AI reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused Fomantic UI-derived CSS rules and trims legacy vendor-prefixed mask declarations where unprefixed equivalents exist.

Changes:

  • Removed large sets of apparently-unused Fomantic UI selectors across component modules (grid/table/menu/message/etc).
  • Deleted page-specific/org-specific legacy styling blocks that no longer have matching markup.
  • Removed -webkit-mask-* declarations in favor of standard mask-* properties.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
web_src/css/shared/settings.css Removes prefixed -webkit-mask-* on toggle icon styling.
web_src/css/review.css Removes prefixed -webkit-mask-* for review warning icon.
web_src/css/org.css Removes legacy invite page #invite-box styling rules.
web_src/css/modules/table.css Removes unused .ui.table width variants (7/9/12–16 wide).
web_src/css/modules/segment.css Removes unused .ui.warning.segment rule.
web_src/css/modules/message.css Removes unused attached/bottom/yellow/red variants; keeps warning/error/info/success.
web_src/css/modules/menu.css Removes unused menu variants (center items, fluid tabular width tweak, etc).
web_src/css/modules/label.css Removes unused olive/basic purple/basic grey label variants.
web_src/css/modules/input.css Removes unused textarea/icon-input and circular/link icon positioning rules.
web_src/css/modules/header.css Removes unused header label/attached/warning variants.
web_src/css/modules/grid.css Removes unused grid column-count/relaxed/compact/centered-row-related rules.
web_src/css/modules/form.css Removes unused slider checkbox spacing and grouped inline fields rules.
web_src/css/modules/comment.css Removes unused nested comments/metadata styling from Fomantic comment module.
web_src/css/modules/codeeditor.css Removes prefixed -webkit-mask-* from code editor close icon styling.
web_src/css/modules/checkbox.css Removes prefixed -webkit-mask-* for checkbox/radio masked glyphs.
web_src/css/modules/card.css Removes unused .ui.three.cards layout rules.
web_src/css/modules/button.css Removes unused .btn.small font-size rule.
web_src/css/base.css Removes prefixed -webkit-mask-* from native select arrow icon styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web_src/css/base.css
@silverwind @claude
Restore -webkit-mask-* vendor prefixes
41c3372 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind silverwind changed the title Remove dead Fomantic UI CSS and pre-2023 vendor prefixes Remove dead Fomantic UI CSS Apr 23, 2026
@silverwind silverwind changed the title Remove dead Fomantic UI CSS Remove dead CSS Apr 23, 2026
silverwind and others added 3 commits April 23, 2026 02:55
@silverwind @claude
Restore .ui.warning.header and .ui.warning.segment
3fe72fa 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind @claude
Restore .ui.bottom.attached.header and .ui.bottom.attached.message
20d51d1 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind @claude
Restore .btn.small
645f752 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 23, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2026
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2026
@denyskon denyskon enabled auto-merge (squash) April 24, 2026 09:41
@denyskon denyskon merged commit 58a1330 into go-gitea:main Apr 24, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone Apr 24, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2026
silverwind added a commit to mohammad-rj/gitea that referenced this pull request Apr 24, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into feat/websocket-migration
ec54754 
* origin/main: (127 commits)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
  fix: dump with default zip type produces uncompressed zip (go-gitea#37401)
  Allow fast-forward-only merge when signed commits are required (go-gitea#37335)
  Introduce `ActionRunAttempt` to represent each execution of a run (go-gitea#37119)
  Move review request functions to a standalone file (go-gitea#37358)
  Fix repo init README EOL (go-gitea#37388)
  Fix org team assignee/reviewer lookups for team member permissions (go-gitea#37365)
  Remove external service dependencies in migration tests (go-gitea#36866)
  Extend issue context popup beyond markdown content (go-gitea#36908)
  fix: commit status reporting (go-gitea#37372)
  Support for Custom URI Schemes in OAuth2 Redirect URIs (go-gitea#37356)
  Fix cmd tests by mocking builtin paths (go-gitea#37369)
  chore: upgrade Go version in devcontainer image to 1.26 (go-gitea#37374)
  Fix button layout shift when collapsing file tree in editor (go-gitea#37363)
  Update `Block a user` form (go-gitea#37359)
  Remove IsValidExternalURL/IsAPIURL and use IsValidURL at call sites (go-gitea#37364)
  ...

# Conflicts:
#	modules/eventsource/event.go
#	tests/e2e/events.test.ts
silverwind added a commit to TheFox0x7/gitea that referenced this pull request Apr 24, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into pr-37105-modernrc-sqlite
68ebe73 
* origin/main:
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 25, 2026
@silverwind @claude
Remove unused .ui.{error,warning}.header CSS
07f5f43 
These selectors carry over from Fomantic and have no usage in
templates, Vue, JS, or Go code. The previous dead-CSS pass (go-gitea#37376)
kept .ui.warning.header as a symmetric pair, but neither variant is
actually consumed.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 25, 2026
@silverwind @claude
Keep .ui.warning.header as symmetric pair
217ecca 
Matches the intent of go-gitea#37376 (keep .ui.warning.header alongside
.ui.error.header even though warning has no current usage).

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 25, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into reply
aec2f56 
* origin/main: (51 commits)
  Fix color regressions, add `priority` color (go-gitea#37417)
  [skip ci] Updated translations via Crowdin
  Stabilize e2e logout propagation test (go-gitea#37403)
  refactor: serve site manifest via `/assets/site-manifest.json` endpoint (go-gitea#37405)
  feat(security): set X-Content-Type-Options: nosniff by default (go-gitea#37354)
  Refactor pull request view (1) (go-gitea#37380)
  Improve AGENTS.md (go-gitea#37382)
  Remove dead CSS (go-gitea#37376)
  Add pr-review e2e test and speed up e2e tests (go-gitea#37345)
  Drop Fomantic tab, checkbox and form patches (go-gitea#37377)
  fix: dump with default zip type produces uncompressed zip (go-gitea#37401)
  Allow fast-forward-only merge when signed commits are required (go-gitea#37335)
  Introduce `ActionRunAttempt` to represent each execution of a run (go-gitea#37119)
  Move review request functions to a standalone file (go-gitea#37358)
  Fix repo init README EOL (go-gitea#37388)
  Fix org team assignee/reviewer lookups for team member permissions (go-gitea#37365)
  Remove external service dependencies in migration tests (go-gitea#36866)
  Extend issue context popup beyond markdown content (go-gitea#36908)
  fix: commit status reporting (go-gitea#37372)
  Support for Custom URI Schemes in OAuth2 Redirect URIs (go-gitea#37356)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lunny lunny lunny approved these changes

@denyskon denyskon denyskon approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @lunny @denyskon @GiteaBot