Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-regression
branch
from
8647645 to
2d46087
Compare
github-actions
bot
added
the
docs-update-needed
wxiaoguang
added
the
skip-changelog
wxiaoguang
force-pushed
the
fix-regression
branch
2 times, most recently
from
2e5de22 to
b08ee73
Compare
wxiaoguang
force-pushed
the
fix-regression
branch
from
b08ee73 to
06cd883
Compare
24 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses three unrelated regressions/rough edges across the web issue comment flow, Docker SSH service behavior, and example configuration documentation.
Changes:
- Prevents creating a user comment when the request is only a close/reopen status change (avoids generating an extra blank comment on reopen).
- Adds a restart delay for the Docker
opensshs6 service when it exits with a non-zero code (reduces tight restart loops/CPU spikes). - Clarifies
SSH_ROOT_PATHdocumentation inapp.example.inifor non-builtin SSH usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
routers/web/repo/issue_comment.go |
Adjusts comment-creation conditions so status-only actions don’t create an empty comment; preserves redirect behavior when a real comment is created. |
docker/root/etc/s6/openssh/finish |
Introduces a 3-second sleep on non-zero exit to slow s6 restarts of sshd after failures. |
custom/conf/app.example.ini |
Updates/clarifies comments for SSH_ROOT_PATH and non-builtin SSH key file creation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
TheFox0x7
approved these changes
Apr 7, 2026
GiteaBot
added
lgtm/need 1
bircni
approved these changes
Apr 7, 2026
GiteaBot
added
lgtm/done
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
github-actions
bot
added
the
modifies/api
wxiaoguang
force-pushed
the
fix-regression
branch
from
5ee0619 to
4f76905
Compare
Contributor
Author
|
By the way, made a follow-up fix 4f76905 for #36697 Old code: UploadIssueAttachment -> uploadAttachment -> UploadAttachmentReleaseSizeLimit New code: UploadIssueAttachment -> uploadAttachment -> UploadAttachmentForIssue also cc @TheFox0x7 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 8, 2026
* main: [skip ci] Updated translations via Crowdin Fix various problems (go-gitea#37129) Add support for RPM Errata (updateinfo.xml) (go-gitea#37125) upgrade vite (go-gitea#37126) Bugfix: Apply notify/register mail flags during install load (go-gitea#37120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.