Bugfix: Apply notify/register mail flags during install load#37120
Merged
wxiaoguang merged 5 commits intogo-gitea:mainfrom Apr 7, 2026
Merged
Bugfix: Apply notify/register mail flags during install load#37120wxiaoguang merged 5 commits intogo-gitea:mainfrom
wxiaoguang merged 5 commits intogo-gitea:mainfrom
Conversation
LoadSettingsForInstall now calls loadRegisterMailFrom and loadNotifyMailFrom after loadMailerFrom so app.ini ENABLE_NOTIFY_MAIL and REGISTER_EMAIL_CONFIRM populate the install form and match full startup behavior. Fixes go-gitea#37112
GiteaBot
added
the
lgtm/need 2
bircni
changed the title
bircni
changed the title
lunny
approved these changes
Apr 6, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Apr 7, 2026
wxiaoguang
approved these changes
Apr 7, 2026
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 8, 2026
* main: [skip ci] Updated translations via Crowdin Fix various problems (go-gitea#37129) Add support for RPM Errata (updateinfo.xml) (go-gitea#37125) upgrade vite (go-gitea#37126) Bugfix: Apply notify/register mail flags during install load (go-gitea#37120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadSettingsForInstallonly ranloadMailerFrom, not loadRegisterMailFrom or loadNotifyMailFrom, so Service.RegisterEmailConfirm and Service.EnableNotifyMail were never read from app.ini on the install page.Full startup runs those through loadMailsFrom; the install path was a narrower subset and never included that step—an oversight from when install-specific loading was added
Fixes #37112