Skip to content

Update message severity colors, fix navbar double border#37019

Merged
silverwind merged 6 commits intogo-gitea:mainfrom
silverwind:sevcolors
Mar 28, 2026
Merged

Update message severity colors, fix navbar double border#37019
silverwind merged 6 commits intogo-gitea:mainfrom
silverwind:sevcolors

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Mar 28, 2026 •
edited
Loading

  • Use Primer's muted border and background tokens for error, warning, success, and info message colors.
  • Use default text color instead of per-severity text colors.
  • Replace saturate filter with semibold font weight on message headers.
  • Fix navbar double border when a notification is present.
Screenshot 2026-03-28 at 08 48 43 Screenshot 2026-03-28 at 08 49 02

Navbar with notification:

Screenshot 2026-03-28 at 08 55 22

Without (unchanged):

Screenshot 2026-03-28 at 08 55 29

This PR was written with the help of Claude Opus 4.6

@silverwind @claude
Update message severity colors to match Primer design tokens
2323c44 
Use Primer's muted border and background tokens for error, warning,
success, and info message colors. Use default text color instead of
per-severity text colors. Replace saturate filter with semibold font
weight on message headers.

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 28, 2026
@silverwind silverwind mentioned this pull request Mar 28, 2026
Merged
@silverwind silverwind changed the title Update message severity colors to match Primer design tokens Update message severity colors Mar 28, 2026
@silverwind silverwind changed the title Update message severity colors Update message severity colors, fix navbar double border Mar 28, 2026
wxiaoguang
wxiaoguang reviewed Mar 28, 2026
View reviewed changes
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Mar 28, 2026 •
edited
Loading

It's strange that the "dark" theme colors have different feelings vs GitHub. Maybe our background color is different from them?

(I regret about saying Primer is much better due to I didn't test the dark theme)

So either is fine to me, change the colors or not.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 28, 2026
bircni
bircni approved these changes Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2026
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Mar 28, 2026 •
edited
Loading

Dark theme colors are different because background is different and the colors are semi-opaque. I do agree they look a bit too faded. Will improve.

@silverwind silverwind marked this pull request as draft March 28, 2026 08:18
@silverwind @claude
Use opaque dark theme severity colors adjusted for Gitea background
c99f84d 
Compute Primer semi-transparent tokens against GitHub dark background,
then lighten 5% to compensate for Gitea's lighter dark background.

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Mar 28, 2026 •
edited
Loading

Made color opaque again like before and tweaked slightly. Dark is now more apparant (5% ligher than primer). Light is unchanged.

image

@silverwind @claude
Adjust dark theme severity colors: opaque with +5% saturation
4368f37 
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Mar 28, 2026

One more tweak: 5% more saturation on dark:

image

@silverwind silverwind marked this pull request as ready for review March 28, 2026 08:38
@bircni
Copy link
Copy Markdown
Member

bircni commented Mar 28, 2026

Couldn't we adjust the background?

1 other topic - could you have a look at action job log container - it doesn't support light mode 😔
Just recognized as I never use light mode

@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Mar 28, 2026 •
edited
Loading

Couldn't we adjust the background?

You mean the page background? I do have some ideas for it (want to make it monochrome), but nothing concrete yet. It would affect the whole dark color scheme.

1 other topic - could you have a look at action job log container - it doesn't support light mode 😔

Last I checked, it is in light mode. Previously job log was always dark, but I think that was fixed at some point.

@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Mar 28, 2026

Previously job log was always dark, but I think that was fixed at some point.

Also fixed by feat: Add workflow dependencies visualization (#36248)

@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Mar 28, 2026

Previously job log was always dark, but I think that was fixed at some point.

Also fixed by feat: Add workflow dependencies visualization (#36248)

Ah, I wasn't aware of that one. In any case, it's good that it's now light.

@bircni
Copy link
Copy Markdown
Member

bircni commented Mar 28, 2026

Let's merge it then!

@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Mar 28, 2026

Yes, this is good to go.

@silverwind silverwind enabled auto-merge (squash) March 28, 2026 09:03
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2026
@silverwind silverwind merged commit 896e483 into go-gitea:main Mar 28, 2026
26 checks passed
@silverwind silverwind deleted the sevcolors branch March 28, 2026 09:05
@GiteaBot GiteaBot added this to the 1.26.0 milestone Mar 28, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 28, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into checkpreview
1042d35 
* origin/main:
  Fix relative-time RangeError (go-gitea#37021)
  Restyle Workflow Graph (go-gitea#36912)
  Update message severity colors, fix navbar double border (go-gitea#37019)
  Clean up checkbox cursor styles (go-gitea#37016)
  add missing cron tasks to example ini (go-gitea#37012)
  Add e2e tests for server push events (go-gitea#36879)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2026
@zjjhot
Merge branch 'main' into mainzjj
aaede8e 
* main: (35 commits)
  Correct swagger annotations for enums, status codes, and notification state (go-gitea#37030)
  Update Nix flake (go-gitea#37024)
  Bump go and python versions in nix flake (go-gitea#37031)
  Make task list checkboxes clickable in the preview tab (go-gitea#37010)
  Add support for in_progress event in workflow_run webhook (go-gitea#36979)
  Fix various problems (go-gitea#37029)
  Update AI Contribution Policy (go-gitea#37022)
  Migrate from webpack to vite (go-gitea#37002)
  Upgrade yaml (go-gitea#37015)
  Fix issue label deletion with Actions tokens (go-gitea#37013)
  Hide delete branch or tag buttons in mirror or archived repositories. (go-gitea#37006)
  Update AGENTS.md with additional guidelines (go-gitea#37018)
  Optimize 'refreshAccesses' to perform update without removing then adding (go-gitea#35702)
  Fix relative-time RangeError (go-gitea#37021)
  Restyle Workflow Graph (go-gitea#36912)
  Update message severity colors, fix navbar double border (go-gitea#37019)
  Clean up checkbox cursor styles (go-gitea#37016)
  add missing cron tasks to example ini (go-gitea#37012)
  Add e2e tests for server push events (go-gitea#36879)
  Update JS dependencies (go-gitea#37001)
  ...
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 30, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into cm
2b13bac 
* origin/main: (69 commits)
  Correct swagger annotations for enums, status codes, and notification state (go-gitea#37030)
  Update Nix flake (go-gitea#37024)
  Bump go and python versions in nix flake (go-gitea#37031)
  Make task list checkboxes clickable in the preview tab (go-gitea#37010)
  Add support for in_progress event in workflow_run webhook (go-gitea#36979)
  Fix various problems (go-gitea#37029)
  Update AI Contribution Policy (go-gitea#37022)
  Migrate from webpack to vite (go-gitea#37002)
  Upgrade yaml (go-gitea#37015)
  Fix issue label deletion with Actions tokens (go-gitea#37013)
  Hide delete branch or tag buttons in mirror or archived repositories. (go-gitea#37006)
  Update AGENTS.md with additional guidelines (go-gitea#37018)
  Optimize 'refreshAccesses' to perform update without removing then adding (go-gitea#35702)
  Fix relative-time RangeError (go-gitea#37021)
  Restyle Workflow Graph (go-gitea#36912)
  Update message severity colors, fix navbar double border (go-gitea#37019)
  Clean up checkbox cursor styles (go-gitea#37016)
  add missing cron tasks to example ini (go-gitea#37012)
  Add e2e tests for server push events (go-gitea#36879)
  Update JS dependencies (go-gitea#37001)
  ...

# Conflicts:
#	package.json
#	pnpm-lock.yaml
#	tests/e2e/utils.ts
#	web_src/css/themes/theme-gitea-dark.css
#	web_src/css/themes/theme-gitea-light.css
#	web_src/js/bootstrap.ts
#	web_src/js/features/codeeditor.ts
#	web_src/js/modules/errors.test.ts
#	webpack.config.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@bircni bircni bircni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @wxiaoguang @bircni @GiteaBot