Add e2e tests for server push events by silverwind · Pull Request #36879 · go-gitea/gitea

silverwind · 2026-03-10T07:20:41Z

Add e2e tests for the three server push features:

Notification count: verifies badge appears when another user creates an issue
Stopwatch: verifies stopwatch element is rendered when a stopwatch is active
Logout propagation: verifies logout in one tab triggers redirect in another

Tests are transport-agnostic in preparation for a future WebSocket migration.

Add tests for the three SSE features: notification count updates, stopwatch events, and logout propagation across tabs. Also extract user management helpers (apiCreateUser, apiDeleteUser, loginUser) into the shared e2e utils and use them in register tests. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Remove SSE-specific code (raw EventSource connections) from e2e tests so they work with any transport (EventSource, WebSocket, etc.). - Stopwatch test: verify DOM element instead of raw EventSource data - Logout test: remove EventSource open probe and waitForTimeout - Remove unnecessary 5s sleep from logoutFromWorker (session is already destroyed server-side before the event reaches the client) - Reduce EVENT_SOURCE_UPDATE_TIME from 2s to 1s for faster tests - Raise timeouts for CI (60s assertions, 120s describe) Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Copilot

Pull request overview

Adds Playwright e2e coverage around the UI’s server-push/event-stream driven behaviors (notifications, stopwatch, logout propagation) and introduces supporting e2e utilities/config tweaks to make these tests run quickly and deterministically.

Changes:

Add new events.test.ts covering notification badge, active stopwatch rendering, and cross-tab logout behavior.
Speed up event polling for e2e runs by setting ui.notification.EVENT_SOURCE_UPDATE_TIME=1s.
Extend e2e test utilities with admin user create/delete helpers and per-user auth headers.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
web_src/js/modules/worker.ts	Simplifies worker-triggered logout redirect (removes delay + async).
tools/test-e2e.sh	Sets a faster EventSource update interval for the isolated e2e server.
tests/e2e/utils.ts	Adds API helpers for creating/deleting users and logging in as them.
tests/e2e/register.test.ts	Refactors cleanup to reuse `apiDeleteUser()` helper.
tests/e2e/events.test.ts	New e2e tests for notification count, stopwatch presence, and logout propagation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

tests/e2e/events.test.ts

tests/e2e/utils.ts

- Reorder notification test to login first, then create issue, so the badge appearance is actually driven by server push, not SSR - Pass baseURL to browser.newContext() so relative URLs work in the logout propagation test - Add apiCreateIssue and apiStartStopwatch helpers with retry logic - Add optional headers param to apiCreateRepo for per-user auth - Use helpers instead of raw request.post() calls in event tests - Rename apiBaseUrl to baseUrl as it is the general server URL - Use env.GITEA_TEST_E2E_DOMAIN instead of hardcoded email domain Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

lunny · 2026-03-21T05:46:51Z

last call @go-gitea/technical-oversight-committee

wxiaoguang

// wait for a while because other requests (eg: logout) may be in the flight

Need to handle the "logout" conflicts.

There can be 2 requests:

User clicks /user/logout?redirect_to=....
Worker triggers redirection to /

silverwind · 2026-03-25T19:32:48Z

There can be 2 requests:
1. User clicks /user/logout?redirect_to=....
2. Worker triggers redirection to /

I don't think there can be a conflict. Here is Claude's analysis:

User clicks <a href="/user/logout">
beforeunload fires before the HTTP request is sent (per HTML spec)
port.close() seals the port immediately
Only then does the browser send GET /user/logout
Only then can the server process and emit the SSE event

Maybe it's a problem in non-conformant browsers. I can add a safeguard if you really like.

- Remove 90s describe timeout, reduce assertion timeouts from 60s to 15s - Lower EVENT_SOURCE_UPDATE_TIME from 1s to 500ms for faster event delivery - Parallelize cleanup apiDeleteUser calls - Remove unnecessary timeout on logout propagation assertion Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>

- Add $(WEBPACK_DEST) dependency to test-e2e target so frontend assets are rebuilt when sources change - Parallelize apiCreateRepo and loginUser in notification count test Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>

wxiaoguang · 2026-03-27T06:50:53Z

Not yet, need to refactor some legacy code

wxiaoguang · 2026-03-27T07:00:03Z

``

I don't think there can be a conflict. Here is Claude's analysis:

User clicks

beforeunload fires before the HTTP request is sent (per HTML spec)

It is just lucky enough because I recently refactored the "logout" to a pure href by Implements OIDC RP-Initiated Logout #36724. Otherwise, the old code uses "fetch" to do logout, there was no "beforeunload" before the logout had completed.

dismiss

silverwind · 2026-03-27T10:20:43Z

I don't imagine us ever having more than 1 shared worker, would recommend a generic name. Maybe EventsSharedWorker instead of UserEventsSharedWorker.

wxiaoguang · 2026-03-27T10:21:36Z

I don't imagine us ever having more than 1 shared worker, would recommend a generic name.

It is already a generic name, and it matches /user/events.

In the future, maybe you need WebSocketSharedWorker

silverwind · 2026-03-27T10:24:05Z

Websocket worker would replace the current worker but I don't want to rule out having more than 1, but I think it's highly unlikely.

wxiaoguang · 2026-03-27T10:27:38Z

Websocket worker would replace the current worker but I don't want to rule out having more than 1, but I think it's highly unlikely.

There is always a chance to rename it in the future if new code comes.

Slightly longer names won't harm anyone, it also help to reduce AI hallucination: they just use grep to search the code base.

silverwind · 2026-03-27T10:49:02Z

Fine with me.

* origin/main: Add e2e tests for server push events (go-gitea#36879) # Conflicts: # web_src/js/features/notification.ts # web_src/js/features/stopwatch.ts

* origin/main: Fix relative-time RangeError (go-gitea#37021) Restyle Workflow Graph (go-gitea#36912) Update message severity colors, fix navbar double border (go-gitea#37019) Clean up checkbox cursor styles (go-gitea#37016) add missing cron tasks to example ini (go-gitea#37012) Add e2e tests for server push events (go-gitea#36879)

* main: (35 commits) Correct swagger annotations for enums, status codes, and notification state (go-gitea#37030) Update Nix flake (go-gitea#37024) Bump go and python versions in nix flake (go-gitea#37031) Make task list checkboxes clickable in the preview tab (go-gitea#37010) Add support for in_progress event in workflow_run webhook (go-gitea#36979) Fix various problems (go-gitea#37029) Update AI Contribution Policy (go-gitea#37022) Migrate from webpack to vite (go-gitea#37002) Upgrade yaml (go-gitea#37015) Fix issue label deletion with Actions tokens (go-gitea#37013) Hide delete branch or tag buttons in mirror or archived repositories. (go-gitea#37006) Update AGENTS.md with additional guidelines (go-gitea#37018) Optimize 'refreshAccesses' to perform update without removing then adding (go-gitea#35702) Fix relative-time RangeError (go-gitea#37021) Restyle Workflow Graph (go-gitea#36912) Update message severity colors, fix navbar double border (go-gitea#37019) Clean up checkbox cursor styles (go-gitea#37016) add missing cron tasks to example ini (go-gitea#37012) Add e2e tests for server push events (go-gitea#36879) Update JS dependencies (go-gitea#37001) ...

* origin/main: (69 commits) Correct swagger annotations for enums, status codes, and notification state (go-gitea#37030) Update Nix flake (go-gitea#37024) Bump go and python versions in nix flake (go-gitea#37031) Make task list checkboxes clickable in the preview tab (go-gitea#37010) Add support for in_progress event in workflow_run webhook (go-gitea#36979) Fix various problems (go-gitea#37029) Update AI Contribution Policy (go-gitea#37022) Migrate from webpack to vite (go-gitea#37002) Upgrade yaml (go-gitea#37015) Fix issue label deletion with Actions tokens (go-gitea#37013) Hide delete branch or tag buttons in mirror or archived repositories. (go-gitea#37006) Update AGENTS.md with additional guidelines (go-gitea#37018) Optimize 'refreshAccesses' to perform update without removing then adding (go-gitea#35702) Fix relative-time RangeError (go-gitea#37021) Restyle Workflow Graph (go-gitea#36912) Update message severity colors, fix navbar double border (go-gitea#37019) Clean up checkbox cursor styles (go-gitea#37016) add missing cron tasks to example ini (go-gitea#37012) Add e2e tests for server push events (go-gitea#36879) Update JS dependencies (go-gitea#37001) ... # Conflicts: # package.json # pnpm-lock.yaml # tests/e2e/utils.ts # web_src/css/themes/theme-gitea-dark.css # web_src/css/themes/theme-gitea-light.css # web_src/js/bootstrap.ts # web_src/js/features/codeeditor.ts # web_src/js/modules/errors.test.ts # webpack.config.ts

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2026

github-actions bot added the modifies/frontend label Mar 10, 2026

Rename test describe from "Events" to "events"

fbbb46f

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind changed the title ~~Add e2e tests for server-sent events~~ Add e2e tests for server push events Mar 10, 2026

Reduce test timeout from 120s to 90s

0a8a248

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind requested a review from Copilot March 10, 2026 07:56

Copilot started reviewing on behalf of silverwind March 10, 2026 07:56 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

tests/e2e/events.test.ts Outdated Show resolved Hide resolved

tests/e2e/events.test.ts Show resolved Hide resolved

tests/e2e/events.test.ts Outdated Show resolved Hide resolved

tests/e2e/utils.ts Show resolved Hide resolved

lunny approved these changes Mar 10, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 10, 2026

silverwind and others added 2 commits March 10, 2026 20:01

Generate random test user password instead of hardcoding

5d5322c

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Use JSDoc comment for testUserPassword

0f8db2a

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind added the type/testing label Mar 10, 2026

silverwind added 3 commits March 11, 2026 05:19

Merge branch 'main' into e2eevents

6775064

Merge branch 'main' into e2eevents

d39768b

Merge branch 'main' into e2eevents

096b8a5

wxiaoguang previously requested changes Mar 21, 2026

View reviewed changes

GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2026

silverwind mentioned this pull request Mar 23, 2026

feat: Replace EventSource/SSE with WebSocket — RFC & Implementation Plan #36942

Open

silverwind added 2 commits March 23, 2026 09:43

Merge branch 'main' into e2eevents

b55ed83

Merge branch 'main' into e2eevents

81df3c6

silverwind and others added 2 commits March 25, 2026 21:48

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 27, 2026

wxiaoguang force-pushed the e2eevents branch from 628a8ff to 8d4fc57 Compare March 27, 2026 07:14

refactor legacy shared worker code

1d950fa

wxiaoguang force-pushed the e2eevents branch from 8d4fc57 to 1d950fa Compare March 27, 2026 07:19

wxiaoguang added 4 commits March 27, 2026 15:26

rename

a5c9ee2

use UserEventsSharedWorker class directly

e603380

add comment for the delayed logout redirecting behavior

9b6a738

fine tune comment

a1b6af6

wxiaoguang approved these changes Mar 27, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2026

wxiaoguang added 2 commits March 27, 2026 18:08

fix shared worker debug name

732961d

fix comment

b6b1cb6

silverwind merged commit de478c4 into go-gitea:main Mar 27, 2026
26 checks passed

GiteaBot added this to the 1.26.0 milestone Mar 27, 2026

silverwind deleted the e2eevents branch March 27, 2026 10:49

silverwind mentioned this pull request Mar 30, 2026

feat(websocket): Phase 1 & 2 — replace SSE notification count with WebSocket #36965

Open

Uh oh!

Conversation

silverwind commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lunny commented Mar 21, 2026

Uh oh!

wxiaoguang left a comment

Choose a reason for hiding this comment

Uh oh!

silverwind commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Mar 27, 2026

Uh oh!

wxiaoguang commented Mar 27, 2026

Uh oh!

silverwind commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Mar 27, 2026

Uh oh!

silverwind commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

silverwind commented Mar 10, 2026 •

edited

Loading

silverwind commented Mar 25, 2026 •

edited

Loading

silverwind commented Mar 27, 2026 •

edited

Loading

wxiaoguang commented Mar 27, 2026 •

edited

Loading

silverwind commented Mar 27, 2026 •

edited

Loading