Fix CRAN package version validation to allow more than 4 version components#36813
Merged
wxiaoguang merged 2 commits intomainfrom Mar 3, 2026
Merged
Fix CRAN package version validation to allow more than 4 version components#36813wxiaoguang merged 2 commits intomainfrom
wxiaoguang merged 2 commits intomainfrom
Conversation
Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with uploading R packages to Gitea CRAN repo
Fix CRAN package version validation to allow more than 4 version components
Mar 3, 2026
wxiaoguang
approved these changes
Mar 3, 2026
TheFox0x7
approved these changes
Mar 3, 2026
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 3, 2026
…onents (go-gitea#36813) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 4, 2026
* giteaofficial/main:
[skip ci] Updated translations via Crowdin
fix: /repos/{owner}/{repo}/actions/{runs,jobs} requiring owner permissions (go-gitea#36818)
Fix CRAN package version validation to allow more than 4 version components (go-gitea#36813)
Fix API not persisting pull request unit config when has_pull_requests is not set (go-gitea#36718)
feat: Add Actions API rerun endpoints for runs and jobs (go-gitea#36768)
Fix bug when pushing mirror with wiki (go-gitea#36795)
Pull Request Pusher should be the author of the merge (go-gitea#36581)
Delete non-exist branch should return 404 (go-gitea#36694)
Remove API registration-token (go-gitea#36801)
Add background and run count to actions list page (go-gitea#36707)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 6, 2026
* origin/main: (27 commits) Fix OAuth2 authorization code expiry and reuse handling (go-gitea#36797) Fix org permission API visibility checks for hidden members and private orgs (go-gitea#36798) Fix non-admins unable to automerge PRs from forks (go-gitea#36833) upgrade to github.com/cloudflare/circl 1.6.3, svgo 4.0.1, markdownlint-cli 0.48.0 (go-gitea#36837) Fix dump release asset bug (go-gitea#36799) build(deps): update material-icon-theme v5.32.0 (go-gitea#36832) Fix bug to check whether user can update pull request branch or rebase branch (go-gitea#36465) Fix forwarded proto handling for public URL detection (go-gitea#36810) Fix artifacts v4 backend upload problems (go-gitea#36805) Add a git grep search timeout (go-gitea#36809) fix(repo): unify DEFAULT_SHOW_FULL_NAME output in templates and dropdown (go-gitea#36597) Harden render iframe open-link handling (go-gitea#36811) [skip ci] Updated translations via Crowdin fix: /repos/{owner}/{repo}/actions/{runs,jobs} requiring owner permissions (go-gitea#36818) Fix CRAN package version validation to allow more than 4 version components (go-gitea#36813) Fix API not persisting pull request unit config when has_pull_requests is not set (go-gitea#36718) feat: Add Actions API rerun endpoints for runs and jobs (go-gitea#36768) Fix bug when pushing mirror with wiki (go-gitea#36795) Pull Request Pusher should be the author of the merge (go-gitea#36581) Delete non-exist branch should return 404 (go-gitea#36694) ... # Conflicts: # routers/web/repo/issue_view.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R packages like
RcppEigenuse versions with 5+ components (e.g.,0.3.4.0.2), which were rejected with "package version is invalid" due to an overly restrictive regex.R's
numeric_versionspec imposes no upper bound on version components, so the{1,3}quantifier (limiting to 4 total components) was incorrect.Changes
modules/packages/cran/metadata.go: Relax version regex from{1,3}to+, accepting any number of dot/dash-separated integer components ≥ 2:modules/packages/cran/metadata_test.go: Remove1.2.3.4.5/1-2-3-4-5from the invalid-version list; addValidVersionManyComponentstest covering0.3.4.0.2,1.2.3.4.5, and1-2-3-4-5.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.