Skip to content

Remove API registration-token#36801

Merged
lunny merged 5 commits intogo-gitea:mainfrom
lunny:lunny/remove_get_registration-token
Mar 2, 2026
Merged

Remove API registration-token#36801
lunny merged 5 commits intogo-gitea:mainfrom
lunny:lunny/remove_get_registration-token

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Mar 2, 2026

Replace #36793

@lunny lunny added type/bug pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Mar 2, 2026
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2026
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Mar 2, 2026
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GET" only

image

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2026
@ChristopherHX
Copy link
Copy Markdown
Contributor

"GET" only

image

The post endpoint of this exists, but is below /admin/actions/runners for consistency with other runner apis.

Removed this from api.go.

@wxiaoguang wxiaoguang dismissed their stale review March 2, 2026 12:55

dismiss

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 2, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2026
@lunny
Copy link
Copy Markdown
Member Author

lunny commented Mar 2, 2026

"GET" only

image

This Get endpoint have no permission problem, so that I didn't remove it.

@ChristopherHX
Copy link
Copy Markdown
Contributor

This Get endpoint have no permission problem, so that I didn't remove it.

I am not entirely sure about this. So /admin/* is never available readonly?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2026
@lunny lunny merged commit 716a800 into go-gitea:main Mar 2, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Mar 2, 2026
@lunny lunny deleted the lunny/remove_get_registration-token branch March 2, 2026 18:31
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2026
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  fix: /repos/{owner}/{repo}/actions/{runs,jobs} requiring owner permissions (go-gitea#36818)
  Fix CRAN package version validation to allow more than 4 version components (go-gitea#36813)
  Fix API not persisting pull request unit config when has_pull_requests is not set (go-gitea#36718)
  feat: Add Actions API rerun endpoints for runs and jobs (go-gitea#36768)
  Fix bug when pushing mirror with wiki (go-gitea#36795)
  Pull Request Pusher should be the author of the merge (go-gitea#36581)
  Delete non-exist branch should return 404 (go-gitea#36694)
  Remove API registration-token (go-gitea#36801)
  Add background and run count to actions list page (go-gitea#36707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants