Move jobparser from act repository to Gitea#36699
Conversation
|
Good call moving this here imho. |
|
CI failures are related. |
|
Looks like a regression in this code snipped, is this due to me switching to yaml.v4... gitea/services/actions/workflow.go Lines 136 to 149 in 3716ed8 Needs investigation, in worst case revert to yaml v3. |
If "jobparser" is only used in Gitea, should upstream delete this package first? |
|
|
And one more question: should we remove this "replace"? Just use "gitea.com/gitea/act" directly
|
|
Yes please remove that |
Then we would need a PR to gitea/act first to replace this in all modules, yes this makes sense for me as well. This does not 100% look to be in scope of this PR. (At least I think that we are forced to (one exception is the fork is of an executable, then go does not care), please correct me if I am wrong) |
ChristopherHX
left a comment
There was a problem hiding this comment.
I would have preserved the original authors as coauthors, other than that this looks good now.
The ci failure
- was unrelated to the yaml v4 version in go.mod
- the problem was the model used yaml.Node v4 and the yaml.Unmarshal v3 (that left the yaml.Node v4 fields blank)
This package was newly introduced by the Gitea maintainers specifically for Gitea. Therefore, the copyright holder “Gitea Authors” is appropriate. Since the original files did not include a copyright year, I have added “2026” consistently to all of these files. |
|
Yes copyright is fine, I know |
* giteaofficial/main: (81 commits) Add keyboard shortcuts for repository file and code search (go-gitea#36416) Refactor text utility classes to Tailwind CSS (go-gitea#36703) Prevent redirect bypasses via backslash-encoded paths (go-gitea#36660) Fix force push time-line commit comments of pull request (go-gitea#36653) Fix get release draft permission check (go-gitea#36659) Move `X_FRAME_OPTIONS` setting from `cors` to `security` section (go-gitea#30256) Update JS and PY deps (go-gitea#36708) Move jobparser from act repository to Gitea (go-gitea#36699) Fix push time bug (go-gitea#36693) Add icon to buttons "Close with Comment", "Close Pull Request", "Close Issue" (go-gitea#36654) various fixes (go-gitea#36697) Add AI Contribution Policy to CONTRIBUTING.md (go-gitea#36651) Add some validation on values provided to USER_DISABLED_FEATURES and EXTERNAL_USER_DISABLED_FEATURES (go-gitea#36688) Rework e2e tests (go-gitea#36634) Remove unused functions (go-gitea#36672) Add migration http transport for push/sync mirror lfs (go-gitea#36665) Fix track time issue id (go-gitea#36664) Refactor inline style attributes (go-gitea#36652) Update Nix flake (go-gitea#36679) Upgrade gogit to 5.16.5 (go-gitea#36680) ... # Conflicts: # web_src/js/features/repo-issue-content.ts
The jobparser sub package in act is only used by Gitea. Move it to Gitea to make it more easier to maintain. --------- Co-authored-by: Christopher Homberger <christopher.homberger@web.de>
The jobparser sub package in act is only used by Gitea. Move it to Gitea to make it more easier to maintain.